Removed font style application in TrayItemMore::ViewHierarchyChanged().

Removed font style application in TrayItemMore::ViewHierarchyChanged().

Applying the style is already handled by the
TrayItemMore::OnNativeThemeChanged() method for all cases that the
ViewHierarchyChanged() was thought to be required for.

BUG=None

Committed: https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd
Cr-Commit-Position: refs/heads/master@{#420141}

[bruthig, 2016-09-21 19:21:13]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:21:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-09-21 19:21:43]

bruthig@chromium.org changed reviewers:
+ tdanderson@chromium.org

[bruthig, 2016-09-21 19:21:44]

Terry, can you take a quick look?

[tdanderson, 2016-09-21 19:27:59]

lgtm with one question

https://codereview.chromium.org/2362443002/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_item_more.cc (right):

https://codereview.chromium.org/2362443002/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_item_more.cc:59: label_->SetText(label);
Do you want to call UpdateStyle() here and/or before line 39?

[bruthig, 2016-09-21 19:37:10]

https://codereview.chromium.org/2362443002/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/tray_item_more.cc (right):

https://codereview.chromium.org/2362443002/diff/20001/ash/common/system/tray/...
ash/common/system/tray/tray_item_more.cc:59: label_->SetText(label);
On 2016/09/21 19:27:59, tdanderson wrote:
> Do you want to call UpdateStyle() here and/or before line 39?

Negative.  I would possibly want to apply the style after the construction of
the |label_| IF it were being created after this View has been added to a View
tree that had a widget.  But since |label_| is being added in the constructor it
can't/won't have the correct native theme to apply and OnNativeThemeChanged()
must be called before painting it.

[commit-bot: I haz the power, 2016-09-21 19:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:49:08]

Dry run: This issue passed the CQ dry run.

[bruthig, 2016-09-21 19:51:42]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:52:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 19:57:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 20:00:22]

Description was changed from

==========
Removed font style application in TrayItemMore::ViewHierarchyChanged().

Applying the style is already handled by the
TrayItemMore::OnNativeThemeChanged() method for all cases that the
ViewHierarchyChanged() was thought to be required for.

BUG=None
==========

to

==========
Removed font style application in TrayItemMore::ViewHierarchyChanged().

Applying the style is already handled by the
TrayItemMore::OnNativeThemeChanged() method for all cases that the
ViewHierarchyChanged() was thought to be required for.

BUG=None

Committed: https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd
Cr-Commit-Position: refs/heads/master@{#420141}
==========

[commit-bot: I haz the power, 2016-09-21 20:00:24]

Patchset 2 (id:??) landed as
https://crrev.com/fead623c450a13f61dece0fcb4cea0b959c9a3dd
Cr-Commit-Position: refs/heads/master@{#420141}