Removed font style application in TrayItemMore::ViewHierarchyChanged().

ash/common/system/tray/tray_item_more.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_item_more.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "ash/common/system/tray/fixed_sized_image_view.h"
 #include "ash/common/system/tray/system_tray_item.h"
 #include "ash/common/system/tray/tray_constants.h"
@@ skipping 38 matching lines @@
                           .GetImageNamed(IDR_AURA_UBER_TRAY_MORE)
                           .ToImageSkia());
     }
     AddChildView(more_);
   }
 }
 
 TrayItemMore::~TrayItemMore() {}
 
 void TrayItemMore::SetLabel(const base::string16& label) {
   label_->SetText(label);

[tdanderson, 2016/09/21 19:27:59]

Do you want to call UpdateStyle() here and/or before line 39?

[bruthig, 2016/09/21 19:37:10]

Negative.  I would possibly want to apply the style after the construction of
the |label_| IF it were being created after this View has been added to a View
tree that had a widget.  But since |label_| is being added in the constructor it
can't/won't have the correct native theme to apply and OnNativeThemeChanged()
must be called before painting it.

   Layout();
   SchedulePaint();
 }
 
 void TrayItemMore::SetImage(const gfx::ImageSkia& image_skia) {
   icon_->SetImage(image_skia);
   SchedulePaint();
 }
 
 void TrayItemMore::SetAccessibleName(const base::string16& name) {
@@ skipping 39 matching lines @@
     label_->SetBoundsRect(bounds);
   }
 }
 
 void TrayItemMore::GetAccessibleState(ui::AXViewState* state) {
   ActionableView::GetAccessibleState(state);
   if (!accessible_name_.empty())
     state->name = accessible_name_;
 }
 
-void TrayItemMore::ViewHierarchyChanged(
-    const ViewHierarchyChangedDetails& details) {
-  ActionableView::ViewHierarchyChanged(details);
-
-  if (details.is_add && details.child == this)
-    UpdateStyle();
-}
-
 void TrayItemMore::OnNativeThemeChanged(const ui::NativeTheme* theme) {
   ActionableView::OnNativeThemeChanged(theme);
   UpdateStyle();
 }
 
 }  // namespace ash