Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2362383002: Subresource Filter: Fix browsertest to preserve feature flags (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
Reviewers:
engedy
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subresource Filter: Fix browsertest to preserve feature flags Since the browsertest modifies the feature flags after browser startup, it can lead to inconsistent and unexpected behavior. This CL preserves the existing features flags. BUG=649783 Committed: https://crrev.com/a9d229b2bee6d538cc2c79930c7ad0ae404e25be Cr-Commit-Position: refs/heads/master@{#420701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M components/subresource_filter/core/browser/subresource_filter_features_test_support.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
tommycli
engedy: PTAL, this patch implements your suggested fix. It passed trybots here: https://codereview.chromium.org/2360083003/ Thanks!
4 years, 3 months ago (2016-09-23 19:04:51 UTC) #3
engedy
Awesome, thank you, LGTM. I have filed a bug and updated the CL description with ...
4 years, 3 months ago (2016-09-23 19:23:55 UTC) #6
tommycli
engedy: thank you for the suggested fix and quick response time!
4 years, 3 months ago (2016-09-23 19:30:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362383002/1
4 years, 3 months ago (2016-09-23 19:30:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 19:46:55 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:49:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9d229b2bee6d538cc2c79930c7ad0ae404e25be
Cr-Commit-Position: refs/heads/master@{#420701}

Powered by Google App Engine
This is Rietveld 408576698