[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728
Committed: https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Committed: https://crrev.com/0952e991d96c311fc55a4cf26506d4f5357f2f7d
Cr-Original-Commit-Position: refs/heads/master@{#420907}
Cr-Commit-Position: refs/heads/master@{#422461}

[tommycli, 2016-09-21 21:16:00]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:16:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 21:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:18:02]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-09-21 21:27:07]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:27:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 22:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 22:08:38]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tommycli, 2016-09-21 23:11:04]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:11:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:52:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[engedy, 2016-09-23 17:42:49]

engedy@chromium.org changed reviewers:
+ engedy@chromium.org

[engedy, 2016-09-23 17:42:50]

components/subresource_filter LGTM % comments, thanks for fixing this!

I think it makes sense to run this change through the trybots in once piece. 
After that, I can imagine splitting it into two parts.

https://codereview.chromium.org/2360083003/diff/40001/components/subresource_...
File
components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
(right):

https://codereview.chromium.org/2360083003/diff/40001/components/subresource_...
components/subresource_filter/core/browser/subresource_filter_features_test_support.cc:55:
base::FeatureList::GetInstance()->GetFeatureOverrides(&enabled_features,
nit: We should first check here if base::FeatureList::GetInstance() is non-null,
and only copy over existing features then.

https://codereview.chromium.org/2360083003/diff/40001/components/subresource_...
components/subresource_filter/core/browser/subresource_filter_features_test_support.cc:57:
feature_list->InitializeFromCommandLine(enabled_features, disabled_features);
Turns out, for the given feature, only the first enable/disable override will
take effect. So in order to make sure that override is the one with the field
trial, we just need to swap this with line 59, and all will be well.

[tommycli, 2016-09-23 17:56:01]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 17:56:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:00:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:01:00]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-09-23 19:05:53]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2016-09-23 19:06:08]

tommycli@chromium.org changed reviewers:
+ rkaplow@chromium.org

[tommycli, 2016-09-23 19:06:09]

rkaplow: PTAL, this depends on a different CL (reviewed by engedy)

[commit-bot: I haz the power, 2016-09-23 19:06:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:53:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 19:53:17]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2016-09-26 14:01:29]

lgtm

[tommycli, 2016-09-26 15:23:42]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-09-26 15:23:43]

The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/2360083003/#ps80001
(title: "Split off subresource filter changes to separate CL")

[tommycli, 2016-09-26 15:23:50]

thanks all!

[commit-bot: I haz the power, 2016-09-26 15:24:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 16:42:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-26 16:44:32]

Description was changed from

==========
[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728
==========

to

==========
[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728

Committed: https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Cr-Commit-Position: refs/heads/master@{#420907}
==========

[commit-bot: I haz the power, 2016-09-26 16:44:33]

Patchset 5 (id:??) landed as
https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Cr-Commit-Position: refs/heads/master@{#420907}

[robliao, 2016-09-30 22:56:29]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2375153008/ by robliao@chromium.org.

The reason for reverting is: Speculative revert to see if
smoothness.scrolling_tough_ad_cases Improves.

[robliao, 2016-10-03 17:26:44]

Description was changed from

==========
[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728

Committed: https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Cr-Commit-Position: refs/heads/master@{#420907}
==========

to

==========
[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728

Committed: https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Cr-Commit-Position: refs/heads/master@{#420907}
==========

[robliao, 2016-10-03 17:27:15]

On 2016/09/30 22:56:29, robliao wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/2375153008/ by mailto:robliao@chromium.org.
> 
> The reason for reverting is: Speculative revert to see if
> smoothness.scrolling_tough_ad_cases Improves.

Reapplying this patch as the perfbots didn't improve with the revert.

[robliao, 2016-10-03 17:27:23]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-10-03 17:28:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 18:12:55]

Description was changed from

==========
[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728

Committed: https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Cr-Commit-Position: refs/heads/master@{#420907}
==========

to

==========
[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728

Committed: https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Cr-Commit-Position: refs/heads/master@{#420907}
==========

[commit-bot: I haz the power, 2016-10-03 18:12:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-03 18:15:36]

Description was changed from

==========
[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728

Committed: https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Cr-Commit-Position: refs/heads/master@{#420907}
==========

to

==========
[HBD] Add Field Trial testing config for PreferHtmlOverPlugins

BUG=626728

Committed: https://crrev.com/41667aa90a95103ac486a938b1b513bf33a72613
Committed: https://crrev.com/0952e991d96c311fc55a4cf26506d4f5357f2f7d
Cr-Original-Commit-Position: refs/heads/master@{#420907}
Cr-Commit-Position: refs/heads/master@{#422461}
==========

[commit-bot: I haz the power, 2016-10-03 18:15:38]

Patchset 5 (id:??) landed as
https://crrev.com/0952e991d96c311fc55a4cf26506d4f5357f2f7d
Cr-Commit-Position: refs/heads/master@{#422461}