Support datalist for date/time input types on Android

ui/android/java/res/layout/date_time_suggestion_item.xml

Index: ui/android/java/res/layout/date_time_suggestion_item.xml
diff --git a/ui/android/java/res/layout/date_time_suggestion_item.xml b/ui/android/java/res/layout/date_time_suggestion_item.xml
new file mode 100644
index 0000000000000000000000000000000000000000..7a10cbe575db2969bfe3ffe807bb8868fd07fec4
--- /dev/null
+++ b/ui/android/java/res/layout/date_time_suggestion_item.xml
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="utf-8"?>

[newt (away), 2013/10/09 07:20:52]

IMO, this could be renamed just date_time_suggestion.xml. I don't think "item"
adds anything useful.

[keishi, 2013/10/21 17:00:58]

Done.

+<!-- Copyright 2013 The Chromium Authors. All rights reserved.
+
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file.
+-->
+
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

[newt (away), 2013/10/09 07:20:52]

indentation should be:

    <LinearLayout xmlns:android="..."
        android:id="...
        ... >
        <TextView
            android:id="..."
            ... />

[keishi, 2013/10/21 17:00:58]

Done.

+              android:id="@+id/date_time_suggestion_item"
+              android:layout_width="fill_parent"

[newt (away), 2013/10/09 07:20:52]

s/fill_parent/match_parent/g

[keishi, 2013/10/21 17:00:58]

Done.

[keishi, 2013/10/21 17:00:58]

Done.

+              android:layout_height="44dp"
+              android:minHeight="44dp"

[newt (away), 2013/10/09 07:20:52]

don't need minHeight="44dp" if you also have layout_height="44dp"

+              android:orientation="horizontal"
+              android:gravity="center_vertical">
+    <TextView android:id="@+id/date_time_suggestion_value"
+              android:layout_width="wrap_content"
+              android:layout_height="wrap_content"
+              android:ellipsize="end"
+              android:singleLine="true"
+              android:textSize="18sp"
+              android:includeFontPadding="false"

[newt (away), 2013/10/09 07:20:52]

why make this false? when this is false, the text's vertical alignment is
affected by whether it contains any descenders or ascenders. as a result, the
values and the labels often won't have their baselines aligned

[keishi, 2013/10/21 17:00:58]

Removed. I copied this file from Android Studio and forgot to fix it.

+              android:layout_marginStart="10dp"

[newt (away), 2013/10/09 07:20:52]

layout_* attributes should be group together at the top (after android:id)

[keishi, 2013/10/21 17:00:58]

Done.

+              android:layout_marginEnd="10dp"/>
+    <TextView android:id="@+id/date_time_suggestion_label"
+              android:layout_width="wrap_content"

[newt (away), 2013/10/09 07:20:52]

use layout_width="0dp". this'll ensure the date_time_suggestion_value gets as
much space as it needs, and this TextView takes up an leftover space

[keishi, 2013/10/21 17:00:58]

Done.

+              android:layout_height="wrap_content"
+              android:textSize="18sp"
+              android:gravity="end"
+              android:textColor="#8b8b8b"
+              android:ellipsize="end"
+              android:singleLine="true"
+              android:minWidth="500dp"

[newt (away), 2013/10/09 07:20:52]

you shouldn't need minWidth here

[keishi, 2013/10/21 17:00:58]

Done.

+              android:includeFontPadding="false"
+              android:layout_marginEnd="10dp"
+              android:layout_weight="1"/>
+</LinearLayout>