ui/android/java/res/layout/date_time_suggestion_item.xml - Issue 23623019: Support datalist for date/time input types on Android

Side by Side Diff: ui/android/java/res/layout/date_time_suggestion_item.xml

Issue 23623019: Support datalist for date/time input types on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	newt (away) 2013/10/09 07:20:52 IMO, this could be renamed just date_time_suggesti IMO, this could be renamed just date_time_suggestion.xml. I don't think "item" adds anything useful. keishi 2013/10/21 17:00:58 Done. Show quoted text On 2013/10/09 07:20:52, newt wrote: > IMO, this could be renamed just date_time_suggestion.xml. I don't think "item" > adds anything useful. Done.
	2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
	newt (away) 2013/10/09 07:20:52 indentation should be: <LinearLayout xmlns:an indentation should be: <LinearLayout xmlns:android="..." android:id="... ... > <TextView android:id="..." ... /> keishi 2013/10/21 17:00:58 Done. Show quoted text On 2013/10/09 07:20:52, newt wrote: > indentation should be: > > <LinearLayout xmlns:android="..." > android:id="... > ... > > <TextView > android:id="..." > ... /> Done.
	9 android:id="@+id/date_time_suggestion_item"

	10 android:layout_width="fill_parent"
	newt (away) 2013/10/09 07:20:52 s/fill_parent/match_parent/g s/fill_parent/match_parent/g keishi 2013/10/21 17:00:58 Done. Show quoted text On 2013/10/09 07:20:52, newt wrote: > s/fill_parent/match_parent/g Done. keishi 2013/10/21 17:00:58 Done. Show quoted text On 2013/10/09 07:20:52, newt wrote: > s/fill_parent/match_parent/g Done.
	11 android:layout_height="44dp"

	12 android:minHeight="44dp"
	newt (away) 2013/10/09 07:20:52 don't need minHeight="44dp" if you also have layou don't need minHeight="44dp" if you also have layout_height="44dp"
	13 android:orientation="horizontal"

	14 android:gravity="center_vertical">

	15 <TextView android:id="@+id/date_time_suggestion_value"

	16 android:layout_width="wrap_content"

	17 android:layout_height="wrap_content"

	18 android:ellipsize="end"

	19 android:singleLine="true"

	20 android:textSize="18sp"

	21 android:includeFontPadding="false"
	newt (away) 2013/10/09 07:20:52 why make this false? when this is false, the text' why make this false? when this is false, the text's vertical alignment is affected by whether it contains any descenders or ascenders. as a result, the values and the labels often won't have their baselines aligned keishi 2013/10/21 17:00:58 Removed. I copied this file from Android Studio an Show quoted text On 2013/10/09 07:20:52, newt wrote: > why make this false? when this is false, the text's vertical alignment is > affected by whether it contains any descenders or ascenders. as a result, the > values and the labels often won't have their baselines aligned Removed. I copied this file from Android Studio and forgot to fix it.
	22 android:layout_marginStart="10dp"
	newt (away) 2013/10/09 07:20:52 layout_* attributes should be group together at th layout_* attributes should be group together at the top (after android:id) keishi 2013/10/21 17:00:58 Done. Show quoted text On 2013/10/09 07:20:52, newt wrote: > layout_* attributes should be group together at the top (after android:id) Done.
	23 android:layout_marginEnd="10dp"/>

	24 <TextView android:id="@+id/date_time_suggestion_label"

	25 android:layout_width="wrap_content"
	newt (away) 2013/10/09 07:20:52 use layout_width="0dp". this'll ensure the date_ti use layout_width="0dp". this'll ensure the date_time_suggestion_value gets as much space as it needs, and this TextView takes up an leftover space keishi 2013/10/21 17:00:58 Done. Show quoted text On 2013/10/09 07:20:52, newt wrote: > use layout_width="0dp". this'll ensure the date_time_suggestion_value gets as > much space as it needs, and this TextView takes up an leftover space Done.
	26 android:layout_height="wrap_content"

	27 android:textSize="18sp"

	28 android:gravity="end"

	29 android:textColor="#8b8b8b"

	30 android:ellipsize="end"

	31 android:singleLine="true"

	32 android:minWidth="500dp"
	newt (away) 2013/10/09 07:20:52 you shouldn't need minWidth here you shouldn't need minWidth here keishi 2013/10/21 17:00:58 Done. Show quoted text On 2013/10/09 07:20:52, newt wrote: > you shouldn't need minWidth here Done.
	33 android:includeFontPadding="false"

	34 android:layout_marginEnd="10dp"

	35 android:layout_weight="1"/>

	36 </LinearLayout>

OLD	NEW

« content/public/common/date_time_suggestion.h ('K') | « content/renderer/renderer_date_time_picker.cc ('k') | no next file » | no next file with comments »