Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2085)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java

Issue 23623019: Support datalist for date/time input types on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java b/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java
index 07c1deb62afcf14263f70d674a795a8df63d340f..8c3be1b49835a17677279e439624d6524a0b4b64 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java
@@ -60,11 +60,11 @@ class DateTimePickerDialog extends AlertDialog implements OnClickListener,
int monthOfYear,
int dayOfMonth,
int hourOfDay, int minute, boolean is24HourView,
- long min, long max) {
+ double min, double max) {
super(context, 0);
- mMinTimeMillis = min;
- mMaxTimeMillis = max;
+ mMinTimeMillis = (long) min;
bulach 2013/12/04 10:37:54 should we instead change these members' types to b
keishi 2013/12/04 12:21:24 I think we should keep it as long. Time and Calen
+ mMaxTimeMillis = (long) max;
mCallBack = callBack;
@@ -81,7 +81,7 @@ class DateTimePickerDialog extends AlertDialog implements OnClickListener,
setView(view);
mDatePicker = (DatePicker) view.findViewById(R.id.date_picker);
DateDialogNormalizer.normalize(mDatePicker, this,
- year, monthOfYear, dayOfMonth, hourOfDay, minute, min, max);
+ year, monthOfYear, dayOfMonth, hourOfDay, minute, mMinTimeMillis, mMaxTimeMillis);
mTimePicker = (TimePicker) view.findViewById(R.id.time_picker);
mTimePicker.setIs24HourView(is24HourView);

Powered by Google App Engine
This is Rietveld 408576698