Support datalist for date/time input types on Android

content/public/android/java/src/org/chromium/content/browser/input/DateTimePickerDialog.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.app.AlertDialog;
 import android.content.Context;
 import android.content.DialogInterface;
 import android.content.DialogInterface.OnClickListener;
@@ skipping 42 matching lines @@
      * @param year The initial year of the dialog.
      * @param monthOfYear The initial month of the dialog.
      * @param dayOfMonth The initial day of the dialog.
      */
     public DateTimePickerDialog(Context context,
             OnDateTimeSetListener callBack,
             int year,
             int monthOfYear,
             int dayOfMonth,
             int hourOfDay, int minute, boolean is24HourView,
-            long min, long max) {
+            double min, double max) {
         super(context, 0);
 
-        mMinTimeMillis = min;
-        mMaxTimeMillis = max;
+        mMinTimeMillis = (long) min;

[bulach, 2013/12/04 10:37:54]

should we instead change these members' types to be double?

[keishi, 2013/12/04 12:21:24]

I think we should keep it as long.

Time and Calendar return number of milliseconds as long.
min/max are double because they may mean different things depending on type,
but mMinTimeMillis/mMaxTimeMillis always represents the number of milliseconds.

+        mMaxTimeMillis = (long) max;
 
         mCallBack = callBack;
 
         setButton(BUTTON_POSITIVE, context.getText(
                 R.string.date_picker_dialog_set), this);
         setButton(BUTTON_NEGATIVE, context.getText(android.R.string.cancel),
                 (OnClickListener) null);
         setIcon(0);
         setTitle(context.getText(R.string.date_time_picker_dialog_title));
 
         LayoutInflater inflater =
                 (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
         View view = inflater.inflate(R.layout.date_time_picker_dialog, null);
         setView(view);
         mDatePicker = (DatePicker) view.findViewById(R.id.date_picker);
         DateDialogNormalizer.normalize(mDatePicker, this,
-                year, monthOfYear, dayOfMonth, hourOfDay, minute, min, max);
+                year, monthOfYear, dayOfMonth, hourOfDay, minute, mMinTimeMillis, mMaxTimeMillis);
 
         mTimePicker = (TimePicker) view.findViewById(R.id.time_picker);
         mTimePicker.setIs24HourView(is24HourView);
         mTimePicker.setCurrentHour(hourOfDay);
         mTimePicker.setCurrentMinute(minute);
         mTimePicker.setOnTimeChangedListener(this);
         onTimeChanged(mTimePicker, mTimePicker.getCurrentHour(),
                 mTimePicker.getCurrentMinute());
     }
 
@@ skipping 56 matching lines @@
      * @param monthOfYear The date month.
      * @param dayOfMonth The date day of month.
      */
     public void updateDateTime(int year, int monthOfYear, int dayOfMonth,
             int hourOfDay, int minutOfHour) {
         mDatePicker.updateDate(year, monthOfYear, dayOfMonth);
         mTimePicker.setCurrentHour(hourOfDay);
         mTimePicker.setCurrentMinute(minutOfHour);
     }
 }