Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 2362233002: Remove HttpNetworkSession::enabled_protocols_. (Closed)

Created:
4 years, 3 months ago by Bence
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HttpNetworkSession::enabled_protocols_. * Remove HttpNetworkSession::enabled_protocols_. * Spell out AlternateProtocol enum values in HttpNetworkSession::IsProtocolEnabled() and in HttpServerProperties::IsAlternateProtocolValid(). * Remove ALTERNATE_PROTOCOL_MAXIMUM_VALID_VERSION, ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION, enum AlternateProtocolSize. BUG=116575 Committed: https://crrev.com/8f8225c9050e63e318e8c12fc26fffe83e6bad05 Cr-Commit-Position: refs/heads/master@{#420731}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -34 lines) Patch
M net/http/http_network_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 2 chunks +11 lines, -20 lines 0 comments Download
M net/http/http_server_properties.h View 1 chunk +0 lines, -11 lines 2 comments Download
M net/http/http_server_properties.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 3 months ago (2016-09-23 14:55:53 UTC) #6
Ryan Hamilton
lgtm Wow, I'm surprised there weren't more places which needed to be changed. Cool. https://codereview.chromium.org/2362233002/diff/1/net/http/http_server_properties.h ...
4 years, 3 months ago (2016-09-23 19:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362233002/1
4 years, 3 months ago (2016-09-23 20:05:03 UTC) #9
Bence
Thank you. https://codereview.chromium.org/2362233002/diff/1/net/http/http_server_properties.h File net/http/http_server_properties.h (left): https://codereview.chromium.org/2362233002/diff/1/net/http/http_server_properties.h#oldcode70 net/http/http_server_properties.h:70: ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION = NPN_HTTP_2, On 2016/09/23 19:23:22, Ryan ...
4 years, 3 months ago (2016-09-23 20:05:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 21:20:20 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 21:22:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f8225c9050e63e318e8c12fc26fffe83e6bad05
Cr-Commit-Position: refs/heads/master@{#420731}

Powered by Google App Engine
This is Rietveld 408576698