Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: net/http/http_network_session.cc

Issue 2362233002: Remove HttpNetworkSession::enabled_protocols_. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_session.cc
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index 66a4eab8b06649bcdb76d4f5142b6912c2fe0bdc..0329c5c278d831fa96eb12b2667fd8552cecd416 100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -208,25 +208,8 @@ HttpNetworkSession::HttpNetworkSession(const Params& params)
websocket_socket_pool_manager_.reset(CreateSocketPoolManager(
WEBSOCKET_SOCKET_POOL, params, ssl_session_cache_shard));
- for (int i = ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION;
- i <= ALTERNATE_PROTOCOL_MAXIMUM_VALID_VERSION; ++i) {
- enabled_protocols_[i - ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION] = false;
- }
-
- // TODO(rtenneti): https://crbug.com/116575
- // Consider combining the NextProto and AlternateProtocol.
if (params_.enable_http2) {
next_protos_.push_back(kProtoHTTP2);
- AlternateProtocol alternate = AlternateProtocolFromNextProto(kProtoHTTP2);
- enabled_protocols_[alternate - ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION] =
- true;
- }
-
- if (params_.enable_quic) {
- AlternateProtocol alternate =
- AlternateProtocolFromNextProto(kProtoQUIC1SPDY3);
- enabled_protocols_[alternate - ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION] =
- true;
}
next_protos_.push_back(kProtoHTTP11);
@@ -356,9 +339,17 @@ void HttpNetworkSession::CloseIdleConnections() {
}
bool HttpNetworkSession::IsProtocolEnabled(AlternateProtocol protocol) const {
- DCHECK(IsAlternateProtocolValid(protocol));
- return enabled_protocols_[
- protocol - ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION];
+ switch (protocol) {
+ case NPN_HTTP_2:
+ return params_.enable_http2;
+ case QUIC:
+ return params_.enable_quic;
+ case UNINITIALIZED_ALTERNATE_PROTOCOL:
+ NOTREACHED();
+ return false;
+ }
+ NOTREACHED();
+ return false;
}
void HttpNetworkSession::GetAlpnProtos(NextProtoVector* alpn_protos) const {

Powered by Google App Engine
This is Rietveld 408576698