third_party/WebKit/Source/core/html/HTMLSlotElement.h - Issue 2362223002: Stop clamping tabIndex to short range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)

Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLSlotElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.h b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

index bc7db2dc972aacb3d4e4425c5bf5136ad54e158d..0faab152c7feb9342878682b2ee40b09a9066eb5 100644

--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

@@ -82,7 +82,7 @@ class CORE_EXPORT HTMLSlotElement final : public HTMLElement {

const AtomicString& newValue,

AttributeModificationReason = ModifiedDirectly) final;

- short tabIndex() const override;

+ int tabIndex() const override;

AtomicString name() const;

// This method can be slow because this has to traverse the children of a