Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2015 Google Inc. All rights reserved. 2 * Copyright (C) 2015 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 void lazyReattachDistributedNodesIfNeeded(); 75 void lazyReattachDistributedNodesIfNeeded();
76 76
77 void attachLayoutTree(const AttachContext& = AttachContext()) final; 77 void attachLayoutTree(const AttachContext& = AttachContext()) final;
78 void detachLayoutTree(const AttachContext& = AttachContext()) final; 78 void detachLayoutTree(const AttachContext& = AttachContext()) final;
79 79
80 void attributeChanged(const QualifiedName&, 80 void attributeChanged(const QualifiedName&,
81 const AtomicString& oldValue, 81 const AtomicString& oldValue,
82 const AtomicString& newValue, 82 const AtomicString& newValue,
83 AttributeModificationReason = ModifiedDirectly) final; 83 AttributeModificationReason = ModifiedDirectly) final;
84 84
85 short tabIndex() const override; 85 int tabIndex() const override;
86 AtomicString name() const; 86 AtomicString name() const;
87 87
88 // This method can be slow because this has to traverse the children of a 88 // This method can be slow because this has to traverse the children of a
89 // shadow host. This method should be used only when m_assignedNodes is 89 // shadow host. This method should be used only when m_assignedNodes is
90 // dirty. e.g. To detect a slotchange event in DOM mutations. 90 // dirty. e.g. To detect a slotchange event in DOM mutations.
91 bool hasAssignedNodesSlow() const; 91 bool hasAssignedNodesSlow() const;
92 bool findHostChildWithSameSlotName() const; 92 bool findHostChildWithSameSlotName() const;
93 93
94 void clearDistribution(); 94 void clearDistribution();
95 void saveAndClearDistribution(); 95 void saveAndClearDistribution();
(...skipping 18 matching lines...) Expand all
114 HeapVector<Member<Node>> m_assignedNodes; 114 HeapVector<Member<Node>> m_assignedNodes;
115 HeapVector<Member<Node>> m_distributedNodes; 115 HeapVector<Member<Node>> m_distributedNodes;
116 HeapVector<Member<Node>> m_oldDistributedNodes; 116 HeapVector<Member<Node>> m_oldDistributedNodes;
117 HeapHashMap<Member<const Node>, size_t> m_distributedIndices; 117 HeapHashMap<Member<const Node>, size_t> m_distributedIndices;
118 bool m_slotchangeEventEnqueued = false; 118 bool m_slotchangeEventEnqueued = false;
119 }; 119 };
120 120
121 } // namespace blink 121 } // namespace blink
122 122
123 #endif // HTMLSlotElement_h 123 #endif // HTMLSlotElement_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOutputElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698