third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp.html - Issue 2362223002: Stop clamping tabIndex to short range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp.html

Issue 2362223002: Stop clamping tabIndex to short range (Closed)

Patch Set: Add a few more subtests to tabindex-clamp.html Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp.html b/third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp.html

index 8561f52cc94378b1947da0d19072dd04e48bd25c..3546e9ee3c7ca83579506af3110bfc2d3c045899 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/tabindex-clamp.html

@@ -21,7 +21,7 @@

logTabIndex(inputs[i]);

}

- var indices = [40000, 32768, 32767, 32766, 0, -1, -32767, -32768, -40000];

+ var indices = [3147483648, 2147483648, 2147483647, 2147483646, 0, -1, -2147483647, -2147483648, -3147483648, "", "foo"];

log('Testing setAttribute on an anchor element made with document.createElement');

@@ -42,20 +42,20 @@

</script>

</head>

- <p>This page tests that the <tt>tabindex</tt> attribute is clamped to

- values between -32768 and 32767. Values outside of this range should be

- clamped to the range limits.</p>

- <input tabindex="40000">

- <input tabindex="32768">

- <input tabindex="32767">

- <input tabindex="32766">

+ <p>This page tests that the <tt>tabindex</tt> attribute is accepted for

+ values between -2147483648 and 2147483647. Values outside of this range will

+ make the tabIndex reflected value zero.</p>

+ <input tabindex="3147483648">

+ <input tabindex="2147483648">

+ <input tabindex="2147483647">

+ <input tabindex="2147483646">

- <input tabindex="-32767">

- <input tabindex="-32768">

- <input tabindex="-32769">

- <input tabindex="-40000">

+ <input tabindex="-2147483647">

+ <input tabindex="-2147483648">

+ <input tabindex="-2147483649">

+ <input tabindex="-3147483648">

</body>