Stop clamping tabIndex to short range

third_party/WebKit/Source/core/dom/ElementRareData.h

Index: third_party/WebKit/Source/core/dom/ElementRareData.h
diff --git a/third_party/WebKit/Source/core/dom/ElementRareData.h b/third_party/WebKit/Source/core/dom/ElementRareData.h
index 223da50f8dbd5322e8d99d8ddb9616e5c69d3295..7a35578e6121c78406e125eeb5f00516cb459914 100644
--- a/third_party/WebKit/Source/core/dom/ElementRareData.h
+++ b/third_party/WebKit/Source/core/dom/ElementRareData.h
@@ -60,15 +60,11 @@ class ElementRareData : public NodeRareData {
   void setPseudoElement(PseudoId, PseudoElement*);
   PseudoElement* pseudoElement(PseudoId) const;
 
-  short tabIndex() const { return m_tabindex; }
-
-  void setTabIndexExplicitly(short index) {
-    m_tabindex = index;
+  void setTabIndexExplicitly(int index) {

[kochi, 2016/11/04 06:49:35]

You can remove the parameter here.

[rwlbuis, 2016/11/04 13:03:18]

Done.

     setElementFlag(TabIndexWasSetExplicitly, true);
   }
 
   void clearTabIndexExplicitly() {
-    m_tabindex = 0;
     clearElementFlag(TabIndexWasSetExplicitly);
   }
 
@@ -192,8 +188,6 @@ class ElementRareData : public NodeRareData {
   CompositorProxiedPropertySet& ensureCompositorProxiedPropertySet();
   void clearCompositorProxiedPropertySet() { m_proxiedProperties = nullptr; }
 
-  short m_tabindex;

[kochi, 2016/11/04 06:49:35]

Didn't you get any error for SameSizeAsElementRareData?

I think if you remove this member, you have to also remove
'short indices[1]' member in SameSizeAsElementRareData in
Element.cpp.

[kochi, 2016/11/04 07:17:04]

I figured out.
The last member of NodeRareData (which is the parent of
ElementRareData class) is a bitfield and take one byte.
As one short can fit in the padding to the next
"LayoutSize" (4-byte aligned).

So the ElementRareData size doesn't change with this anyway,
but you should still remove the 'short indices[1]' line in
SameSizeAsElementRareData in Element.cpp to avoid future
confusion.

[rwlbuis, 2016/11/04 13:03:18]

Thanks for looking into it, I forgot about this. I simply removed the entry in
the struct in my latest patch.

[rwlbuis, 2016/11/04 13:03:18]

Acknowledged.

-
   LayoutSize m_minimumSizeForResizing;
   ScrollOffset m_savedLayerScrollOffset;
 
@@ -226,7 +220,6 @@ inline LayoutSize defaultMinimumSizeForResizing() {
 
 inline ElementRareData::ElementRareData(LayoutObject* layoutObject)
     : NodeRareData(layoutObject),
-      m_tabindex(0),
       m_minimumSizeForResizing(defaultMinimumSizeForResizing()),
       m_classList(nullptr) {
   m_isElementRareData = true;