third_party/WebKit/Source/core/svg/SVGElement.cpp - Issue 2362223002: Stop clamping tabIndex to short range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)

Patch Set: Fix test expectation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp

index c0ce0a4c74c17dd07572d91d4c409ba700e3b4e8..9ed376eb7531e3018537649ea879b44374b37a8a 100644

--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp

@@ -90,7 +90,7 @@ void SVGElement::attachLayoutTree(const AttachContext& context) {

element->mapInstanceToElement(this);

}

-short SVGElement::tabIndex() const {

+int SVGElement::tabIndex() const {

if (supportsFocus())

return Element::tabIndex();

return -1;