Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann
3 * <zimmermann@kde.org> 3 * <zimmermann@kde.org>
4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 6 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 if (SVGElement* element = correspondingElement()) 83 if (SVGElement* element = correspondingElement())
84 element->removeInstanceMapping(this); 84 element->removeInstanceMapping(this);
85 } 85 }
86 86
87 void SVGElement::attachLayoutTree(const AttachContext& context) { 87 void SVGElement::attachLayoutTree(const AttachContext& context) {
88 Element::attachLayoutTree(context); 88 Element::attachLayoutTree(context);
89 if (SVGElement* element = correspondingElement()) 89 if (SVGElement* element = correspondingElement())
90 element->mapInstanceToElement(this); 90 element->mapInstanceToElement(this);
91 } 91 }
92 92
93 short SVGElement::tabIndex() const { 93 int SVGElement::tabIndex() const {
94 if (supportsFocus()) 94 if (supportsFocus())
95 return Element::tabIndex(); 95 return Element::tabIndex();
96 return -1; 96 return -1;
97 } 97 }
98 98
99 void SVGElement::willRecalcStyle(StyleRecalcChange change) { 99 void SVGElement::willRecalcStyle(StyleRecalcChange change) {
100 if (!hasSVGRareData()) 100 if (!hasSVGRareData())
101 return; 101 return;
102 // If the style changes because of a regular property change (not induced by 102 // If the style changes because of a regular property change (not induced by
103 // SMIL animations themselves) reset the "computed style without SMIL style 103 // SMIL animations themselves) reset the "computed style without SMIL style
(...skipping 1124 matching lines...) Expand 10 before | Expand all | Expand 10 after
1228 visitor->trace(m_className); 1228 visitor->trace(m_className);
1229 Element::trace(visitor); 1229 Element::trace(visitor);
1230 } 1230 }
1231 1231
1232 const AtomicString& SVGElement::eventParameterName() { 1232 const AtomicString& SVGElement::eventParameterName() {
1233 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt")); 1233 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt"));
1234 return evtString; 1234 return evtString;
1235 } 1235 }
1236 1236
1237 } // namespace blink 1237 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698