third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 2362223002: Stop clamping tabIndex to short range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)

Patch Set: Fix test expectation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index c1ca835ba68a2f48576f98686fd7a4e67bba48bc..e1d84fa6d1573fb32a2ca4d68722d2d2d7e9cffc 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -406,7 +406,7 @@ void HTMLFormControlElement::willCallDefaultEventHandler(const Event& event) {

FocusControlState);

}

-short HTMLFormControlElement::tabIndex() const {

+int HTMLFormControlElement::tabIndex() const {

// Skip the supportsFocus check in HTMLElement.

return Element::tabIndex();

}