Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 399
400 // Change of m_wasFocusByMouse may affect shouldHaveFocusAppearance() and 400 // Change of m_wasFocusByMouse may affect shouldHaveFocusAppearance() and
401 // LayoutTheme::isFocused(). Inform LayoutTheme if 401 // LayoutTheme::isFocused(). Inform LayoutTheme if
402 // shouldHaveFocusAppearance() changes. 402 // shouldHaveFocusAppearance() changes.
403 if (oldShouldHaveFocusAppearance != shouldHaveFocusAppearance() && 403 if (oldShouldHaveFocusAppearance != shouldHaveFocusAppearance() &&
404 layoutObject()) 404 layoutObject())
405 LayoutTheme::theme().controlStateChanged(*layoutObject(), 405 LayoutTheme::theme().controlStateChanged(*layoutObject(),
406 FocusControlState); 406 FocusControlState);
407 } 407 }
408 408
409 short HTMLFormControlElement::tabIndex() const { 409 int HTMLFormControlElement::tabIndex() const {
410 // Skip the supportsFocus check in HTMLElement. 410 // Skip the supportsFocus check in HTMLElement.
411 return Element::tabIndex(); 411 return Element::tabIndex();
412 } 412 }
413 413
414 bool HTMLFormControlElement::recalcWillValidate() const { 414 bool HTMLFormControlElement::recalcWillValidate() const {
415 if (m_dataListAncestorState == Unknown) { 415 if (m_dataListAncestorState == Unknown) {
416 if (Traversal<HTMLDataListElement>::firstAncestor(*this)) 416 if (Traversal<HTMLDataListElement>::firstAncestor(*this))
417 m_dataListAncestorState = InsideDataList; 417 m_dataListAncestorState = InsideDataList;
418 else 418 else
419 m_dataListAncestorState = NotInsideDataList; 419 m_dataListAncestorState = NotInsideDataList;
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 dispatchFormControlChangeEvent(); 644 dispatchFormControlChangeEvent();
645 } 645 }
646 646
647 void HTMLFormControlElement::copyNonAttributePropertiesFromElement( 647 void HTMLFormControlElement::copyNonAttributePropertiesFromElement(
648 const Element& source) { 648 const Element& source) {
649 HTMLElement::copyNonAttributePropertiesFromElement(source); 649 HTMLElement::copyNonAttributePropertiesFromElement(source);
650 setNeedsValidityCheck(); 650 setNeedsValidityCheck();
651 } 651 }
652 652
653 } // namespace blink 653 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698