Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved. 5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
7 * (http://www.torchmobile.com/) 7 * (http://www.torchmobile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 } 483 }
484 void clearV8CollectableDuringMinorGC() { 484 void clearV8CollectableDuringMinorGC() {
485 setFlag(false, V8CollectableDuringMinorGCFlag); 485 setFlag(false, V8CollectableDuringMinorGCFlag);
486 } 486 }
487 487
488 virtual void setFocused(bool flag); 488 virtual void setFocused(bool flag);
489 virtual void setActive(bool flag = true); 489 virtual void setActive(bool flag = true);
490 virtual void setDragged(bool flag); 490 virtual void setDragged(bool flag);
491 virtual void setHovered(bool flag = true); 491 virtual void setHovered(bool flag = true);
492 492
493 virtual short tabIndex() const; 493 virtual int tabIndex() const;
494 494
495 virtual Node* focusDelegate(); 495 virtual Node* focusDelegate();
496 // This is called only when the node is focused. 496 // This is called only when the node is focused.
497 virtual bool shouldHaveFocusAppearance() const; 497 virtual bool shouldHaveFocusAppearance() const;
498 498
499 // Whether the node is inert. This can't be in Element because text nodes 499 // Whether the node is inert. This can't be in Element because text nodes
500 // must be recognized as inert to prevent text selection. 500 // must be recognized as inert to prevent text selection.
501 bool isInert() const; 501 bool isInert() const;
502 502
503 virtual LayoutRect boundingBox() const; 503 virtual LayoutRect boundingBox() const;
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
1021 } // namespace blink 1021 } // namespace blink
1022 1022
1023 #ifndef NDEBUG 1023 #ifndef NDEBUG
1024 // Outside the WebCore namespace for ease of invocation from gdb. 1024 // Outside the WebCore namespace for ease of invocation from gdb.
1025 void showNode(const blink::Node*); 1025 void showNode(const blink::Node*);
1026 void showTree(const blink::Node*); 1026 void showTree(const blink::Node*);
1027 void showNodePath(const blink::Node*); 1027 void showNodePath(const blink::Node*);
1028 #endif 1028 #endif
1029 1029
1030 #endif // Node_h 1030 #endif // Node_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698