Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementRareData.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 David Smith <catfish.man@gmail.com> 3 * Copyright (C) 2008 David Smith <catfish.man@gmail.com>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 public: 54 public:
55 static ElementRareData* create(LayoutObject* layoutObject) { 55 static ElementRareData* create(LayoutObject* layoutObject) {
56 return new ElementRareData(layoutObject); 56 return new ElementRareData(layoutObject);
57 } 57 }
58 58
59 ~ElementRareData(); 59 ~ElementRareData();
60 60
61 void setPseudoElement(PseudoId, PseudoElement*); 61 void setPseudoElement(PseudoId, PseudoElement*);
62 PseudoElement* pseudoElement(PseudoId) const; 62 PseudoElement* pseudoElement(PseudoId) const;
63 63
64 short tabIndex() const { return m_tabindex; } 64 int tabIndex() const { return m_tabindex; }
65 65
66 void setTabIndexExplicitly(short index) { 66 void setTabIndexExplicitly(int index) {
67 m_tabindex = index; 67 m_tabindex = index;
68 setElementFlag(TabIndexWasSetExplicitly, true); 68 setElementFlag(TabIndexWasSetExplicitly, true);
69 } 69 }
70 70
71 void clearTabIndexExplicitly() { 71 void clearTabIndexExplicitly() {
72 m_tabindex = 0; 72 m_tabindex = 0;
73 clearElementFlag(TabIndexWasSetExplicitly); 73 clearElementFlag(TabIndexWasSetExplicitly);
74 } 74 }
75 75
76 CSSStyleDeclaration& ensureInlineCSSStyleDeclaration(Element* ownerElement); 76 CSSStyleDeclaration& ensureInlineCSSStyleDeclaration(Element* ownerElement);
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 ResizeObserverDataMap& ensureResizeObserverData(); 174 ResizeObserverDataMap& ensureResizeObserverData();
175 175
176 DECLARE_TRACE_AFTER_DISPATCH(); 176 DECLARE_TRACE_AFTER_DISPATCH();
177 177
178 DECLARE_TRACE_WRAPPERS_AFTER_DISPATCH(); 178 DECLARE_TRACE_WRAPPERS_AFTER_DISPATCH();
179 179
180 private: 180 private:
181 CompositorProxiedPropertySet& ensureCompositorProxiedPropertySet(); 181 CompositorProxiedPropertySet& ensureCompositorProxiedPropertySet();
182 void clearCompositorProxiedPropertySet() { m_proxiedProperties = nullptr; } 182 void clearCompositorProxiedPropertySet() { m_proxiedProperties = nullptr; }
183 183
184 short m_tabindex; 184 int m_tabindex;
185 185
186 LayoutSize m_minimumSizeForResizing; 186 LayoutSize m_minimumSizeForResizing;
187 ScrollOffset m_savedLayerScrollOffset; 187 ScrollOffset m_savedLayerScrollOffset;
188 188
189 Member<DatasetDOMStringMap> m_dataset; 189 Member<DatasetDOMStringMap> m_dataset;
190 Member<ElementShadow> m_shadow; 190 Member<ElementShadow> m_shadow;
191 Member<ClassList> m_classList; 191 Member<ClassList> m_classList;
192 Member<NamedNodeMap> m_attributeMap; 192 Member<NamedNodeMap> m_attributeMap;
193 Member<AttrNodeList> m_attrNodeList; 193 Member<AttrNodeList> m_attrNodeList;
194 Member<InlineCSSStyleDeclaration> m_cssomWrapper; 194 Member<InlineCSSStyleDeclaration> m_cssomWrapper;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 inline CompositorProxiedPropertySet& 264 inline CompositorProxiedPropertySet&
265 ElementRareData::ensureCompositorProxiedPropertySet() { 265 ElementRareData::ensureCompositorProxiedPropertySet() {
266 if (!m_proxiedProperties) 266 if (!m_proxiedProperties)
267 m_proxiedProperties = CompositorProxiedPropertySet::create(); 267 m_proxiedProperties = CompositorProxiedPropertySet::create();
268 return *m_proxiedProperties; 268 return *m_proxiedProperties;
269 } 269 }
270 270
271 } // namespace blink 271 } // namespace blink
272 272
273 #endif // ElementRareData_h 273 #endif // ElementRareData_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698