Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/bubble/bubble_delegate.cc

Issue 23622020: Fixing the dynamic positioning (move with anchor) for the app launcher (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/bubble/bubble_delegate.h ('K') | « ui/views/bubble/bubble_delegate.h ('k') | ui/views/bubble/bubble_delegate_unittest.cc » ('j') | ui/views/bubble/bubble_delegate_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_delegate.cc
diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc
index 5eb994395251a7a5a34218fe6b87f3287298c9e9..2ea722d8751588e175b6f6f16b2f1e1512813a52 100644
--- a/ui/views/bubble/bubble_delegate.cc
+++ b/ui/views/bubble/bubble_delegate.cc
@@ -257,6 +257,8 @@ gfx::Rect BubbleDelegateView::GetAnchorRect() {
return anchor_rect_;
gfx::Rect anchor_bounds = anchor_view()->GetBoundsInScreen();
anchor_bounds.Inset(anchor_view_insets_);
+ anchor_bounds.set_x(anchor_bounds.x() + anchor_offset_.x());
msw 2013/09/06 16:32:00 Use Rect::Offset after you make anchor_offset_ a v
Mr4D (OOO till 08-26) 2013/09/06 17:57:31 Not required anymore - removed
+ anchor_bounds.set_y(anchor_bounds.y() + anchor_offset_.y());
return anchor_bounds;
}
« ui/views/bubble/bubble_delegate.h ('K') | « ui/views/bubble/bubble_delegate.h ('k') | ui/views/bubble/bubble_delegate_unittest.cc » ('j') | ui/views/bubble/bubble_delegate_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698