Fixing the dynamic positioning (move with anchor) for the app launcher

ui/views/bubble/bubble_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_delegate.h"
 
 #include "ui/base/animation/slide_animation.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/rect.h"
 #include "ui/native_theme/native_theme.h"
@@ skipping 239 matching lines @@
                                                const gfx::Rect& new_bounds) {
   if (move_with_anchor() && anchor_widget() == widget)
     SizeToContents();
 }
 
 gfx::Rect BubbleDelegateView::GetAnchorRect() {
   if (!anchor_view())
     return anchor_rect_;
   gfx::Rect anchor_bounds = anchor_view()->GetBoundsInScreen();
   anchor_bounds.Inset(anchor_view_insets_);
+  anchor_bounds.set_x(anchor_bounds.x() + anchor_offset_.x());

[msw, 2013/09/06 16:32:00]

Use Rect::Offset after you make anchor_offset_ a vector.

[Mr4D (OOO till 08-26), 2013/09/06 17:57:31]

Not required anymore - removed

+  anchor_bounds.set_y(anchor_bounds.y() + anchor_offset_.y());
   return anchor_bounds;
 }
 
 void BubbleDelegateView::StartFade(bool fade_in) {
 #if defined(USE_AURA)
   // Use AURA's window layer animation instead of fading. This ensures that
   // hosts which rely on the layer animation callbacks to close the window
   // work correctly.
   if (fade_in)
     GetWidget()->Show();
@@ skipping 146 matching lines @@
       border_widget_->ShowInactive();
     if (anchor_widget() && anchor_widget()->GetTopLevelWidget())
       anchor_widget()->GetTopLevelWidget()->DisableInactiveRendering();
   } else {
     if (border_widget_)
       border_widget_->Hide();
   }
 }
 
 }  // namespace views