gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc - Issue 2362163003: [Command buffer] blitFramebuffer should not disable scissor test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

Issue 2362163003: [Command buffer] blitFramebuffer should not disable scissor test (Closed)

Patch Set: Fix bots failure: we don't disable scissor test deliberately now Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/gles2_cmd_srgb_converter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

index 5c0fb2bc152d6b77be967c2380c24a07bf810afd..fe14a776f3199ec8b472d8a75c9c28e776ce3a09 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc

@@ -3684,12 +3684,10 @@ TEST_P(GLES3DecoderTest, BlitFramebufferDisabledReadBuffer) {

1.0f, // depth

false, // scissor test

0, 0, 128, 64);

- SetupExpectationsForEnableDisable(GL_SCISSOR_TEST, false);

EXPECT_CALL(*gl_, BlitFramebufferEXT(0, 0, 1, 1, 0, 0, 1, 1,

GL_COLOR_BUFFER_BIT, GL_LINEAR))

.Times(1)

.RetiresOnSaturation();

- SetupExpectationsForEnableDisable(GL_SCISSOR_TEST, false);

BlitFramebufferCHROMIUM cmd;

cmd.Init(0, 0, 1, 1, 0, 0, 1, 1, GL_COLOR_BUFFER_BIT, GL_LINEAR);

EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));