Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2362163003: [Command buffer] blitFramebuffer should not disable scissor test (Closed)
Patch Set: Fix bots failure: we don't disable scissor test deliberately now Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index c30d501ed0aec6d20eee1c50a3aba65c70d9d5a7..04729340fac78596d4d2eda62d5f0a21714975a8 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -7722,13 +7722,8 @@ void GLES2DecoderImpl::DoBlitFramebufferCHROMIUM(
state_.EnableDisableFramebufferSRGB(enable_srgb);
}
- // TODO(yunchao) Need to revisit here. In GLES spec, blitFramebuffer
- // should do scissor test per fragment operation.
- state_.SetDeviceCapabilityState(GL_SCISSOR_TEST, false);
Zhenyao Mo 2016/09/23 18:35:21 You can only remove this conditionally. The CHROM
BlitFramebufferHelper(
srcX0, srcY0, srcX1, srcY1, dstX0, dstY0, dstX1, dstY1, mask, filter);
- state_.SetDeviceCapabilityState(GL_SCISSOR_TEST,
- state_.enable_flags.scissor_test);
return;
}
@@ -7749,7 +7744,8 @@ void GLES2DecoderImpl::DoBlitFramebufferCHROMIUM(
GetBoundReadFramebufferServiceId(),
src_internal_format, src_format, src_type,
GetBoundDrawFramebufferServiceId(),
- read_buffer_has_srgb, draw_buffers_has_srgb);
+ read_buffer_has_srgb, draw_buffers_has_srgb,
+ state_.enable_flags.scissor_test);
}
bool GLES2DecoderImpl::InitializeSRGBConverter(
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698