Issue 2362163002: Bring back assertions for beginBatchEdit / endBatchEdit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2362163002: Bring back assertions for beginBatchEdit / endBatchEdit (Closed)

Created:
4 years, 3 months ago by Changwan Ryu

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews, jam, darin-cc_chromium.org

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Bring back assertions for beginBatchEdit / endBatchEdit Since there is no known crash for these functions, we will bring back the assertions to fortify the IME thread logic. BUG=643477 Review-Url: https://codereview.chromium.org/2365543002 Cr-Commit-Position: refs/heads/master@{#420560} (cherry picked from commit 1e882835e53cfd89a30e14c806cdbc5a6d0554ac) Committed: https://chromium.googlesource.com/chromium/src/+/0cab1eafcc8b4a1b8efab0b0b82311a70ed10843

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Changwan Ryu

4 years, 3 months ago (2016-09-23 05:47:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0cab1eafcc8b4a1b8efab0b0b82311a70ed10843.