Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2365543002: Bring back assertions for beginBatchEdit / endBatchEdit (Closed)

Created:
4 years, 3 months ago by Changwan Ryu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bring back assertions for beginBatchEdit / endBatchEdit Since there is no known crash for these functions, we will bring back the assertions to fortify the IME thread logic. BUG=643477 Committed: https://crrev.com/1e882835e53cfd89a30e14c806cdbc5a6d0554ac Cr-Commit-Position: refs/heads/master@{#420560}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Changwan Ryu
PTAL
4 years, 3 months ago (2016-09-22 02:50:52 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 3 months ago (2016-09-22 03:00:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365543002/1
4 years, 3 months ago (2016-09-22 06:04:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/146085)
4 years, 3 months ago (2016-09-22 07:22:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365543002/20001
4 years, 3 months ago (2016-09-23 02:28:25 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 03:09:22 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 03:11:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e882835e53cfd89a30e14c806cdbc5a6d0554ac
Cr-Commit-Position: refs/heads/master@{#420560}

Powered by Google App Engine
This is Rietveld 408576698