chrome/common/extensions/manifest_tests/extension_manifest_test.cc - Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifest_test.cc

Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: zip (file-util) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension_file_util_unittest.cc ('K') | « chrome/common/extensions/extension_unittest.cc ('k') | chrome/test/remoting/remote_desktop_browsertest.cc » ('j') | extensions/common/file_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifest_test.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifest_test.cc b/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

index 3b5a118d3af35911d6338eb87607bc9c45993bf9..02f473a25731f6f4fc0be018566f898acfe7d3ae 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifest_test.cc

@@ -39,8 +39,7 @@ base::DictionaryValue* LoadManifestFile(const base::FilePath& filename_path,

// Most unit tests don't need localization, and they'll fail if we try to

// localize them, since their manifests don't have a default_locale key.

// Only localize manifests that indicate they want to be localized.

- // Calling LocalizeExtension at this point mirrors

- // extension_file_util::LoadExtension.

+ // Calling LocalizeExtension at this point mirrors file_util::LoadExtension.

if (manifest &&

filename_path.value().find(FILE_PATH_LITERAL("localized")) !=

std::string::npos)