chrome/common/extensions/extension_unittest.cc - Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: zip (file-util) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension_file_util_unittest.cc ('K') | « chrome/common/extensions/extension_file_util_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifest_test.cc » ('j') | extensions/common/file_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_unittest.cc

diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc

index f0c2c8c6d871f8034f8a5b987845b5e3caf67ced..9fe1027e914aba807a450b5e85cbedc7111aa85a 100644

--- a/chrome/common/extensions/extension_unittest.cc

+++ b/chrome/common/extensions/extension_unittest.cc

@@ -9,12 +9,12 @@

#include "base/strings/stringprintf.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/extensions/command.h"

-#include "chrome/common/extensions/extension_file_util.h"

#include "chrome/common/extensions/extension_test_util.h"

#include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h"

#include "chrome/common/url_constants.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_resource.h"

+#include "extensions/common/file_util.h"

#include "extensions/common/manifest.h"

#include "extensions/common/permissions/permissions_data.h"

#include "net/base/mime_sniffer.h"

@@ -173,8 +173,7 @@ TEST(ExtensionTest, GetAbsolutePathNoError) {

EXPECT_TRUE(extension.get());

std::string err;

std::vector<InstallWarning> warnings;

- EXPECT_TRUE(extension_file_util::ValidateExtension(extension.get(),

- &err, &warnings));

+ EXPECT_TRUE(file_util::ValidateExtension(extension.get(), &err, &warnings));

EXPECT_EQ(0U, warnings.size());

EXPECT_EQ(extension->path().AppendASCII("test.html").value(),