Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.cc

Issue 2362033002: Showing previews UI for Offline Previews (Closed)
Patch Set: Simplified Offline Pages Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
index 59db3ee9b7a344ef09fd94e4a2d37ca00b5e8ef5..d5425ec20a691b4b1bd41e8c7af7e792e7bdfd41 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
@@ -166,11 +166,17 @@ void OfflinePageTabHelper::SetOfflinePage(
provisional_offline_info_.offline_page =
base::MakeUnique<OfflinePageItem>(offline_page);
provisional_offline_info_.offline_header = offline_header;
provisional_offline_info_.is_offline_preview = is_offline_preview;
}
const OfflinePageItem* OfflinePageTabHelper::GetOfflinePageForTest() const {
return provisional_offline_info_.offline_page.get();
}
+bool OfflinePageTabHelper::IsOfflinePreview() const {
+ // TODO: Change this once offline pages infrastructure uses NavigationHandle
+ // instead of a back channel. crbug.com/658899
+ return provisional_offline_info_.is_offline_preview ||
+ offline_info_.is_offline_preview;
+}
jianli 2016/10/25 22:14:16 nit: empty line
RyanSturm 2016/10/25 23:08:26 Done.
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698