Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.cc

Issue 2362033002: Showing previews UI for Offline Previews (Closed)
Patch Set: Simplified Offline Pages Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/offline_page_tab_helper.h" 5 #include "chrome/browser/android/offline_pages/offline_page_tab_helper.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "chrome/browser/android/offline_pages/offline_page_request_job.h" 10 #include "chrome/browser/android/offline_pages/offline_page_request_job.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 provisional_offline_info_.offline_page = 166 provisional_offline_info_.offline_page =
167 base::MakeUnique<OfflinePageItem>(offline_page); 167 base::MakeUnique<OfflinePageItem>(offline_page);
168 provisional_offline_info_.offline_header = offline_header; 168 provisional_offline_info_.offline_header = offline_header;
169 provisional_offline_info_.is_offline_preview = is_offline_preview; 169 provisional_offline_info_.is_offline_preview = is_offline_preview;
170 } 170 }
171 171
172 const OfflinePageItem* OfflinePageTabHelper::GetOfflinePageForTest() const { 172 const OfflinePageItem* OfflinePageTabHelper::GetOfflinePageForTest() const {
173 return provisional_offline_info_.offline_page.get(); 173 return provisional_offline_info_.offline_page.get();
174 } 174 }
175 175
176 bool OfflinePageTabHelper::IsOfflinePreview() const {
177 // TODO: Change this once offline pages infrastructure uses NavigationHandle
178 // instead of a back channel. crbug.com/658899
179 return provisional_offline_info_.is_offline_preview ||
180 offline_info_.is_offline_preview;
181 }
jianli 2016/10/25 22:14:16 nit: empty line
RyanSturm 2016/10/25 23:08:26 Done.
176 } // namespace offline_pages 182 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698