Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase; Renaming of some methods and small changes in StyleDifference Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderLayer.cpp
diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp
index 989cee9d2e3a411f3fd869609955c99650b5fd2e..c4ba85cc89a5d036515f691fa1f5b8a23407bf1c 100644
--- a/Source/core/rendering/RenderLayer.cpp
+++ b/Source/core/rendering/RenderLayer.cpp
@@ -3789,7 +3789,7 @@ void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle
m_scrollableArea->updateAfterStyleChange(oldStyle);
if (!oldStyle || oldStyle->visibility() != renderer()->style()->visibility()) {
- ASSERT(!oldStyle || diff >= StyleDifferenceRepaint);
+ ASSERT(!oldStyle || diff.needsRepaint() || diff.needsLayout());
compositor()->setNeedsUpdateCompositingRequirementsState();
}
@@ -3798,12 +3798,12 @@ void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle
updateSelfPaintingLayer();
if (!oldStyle || renderer()->style()->position() != oldStyle->position()) {
- ASSERT(!oldStyle || diff >= StyleDifferenceLayout);
+ ASSERT(!oldStyle || diff.needsFullLayout());
updateOutOfFlowPositioned(oldStyle);
}
if (!oldStyle || !renderer()->style()->reflectionDataEquivalent(oldStyle)) {
- ASSERT(!oldStyle || diff >= StyleDifferenceLayout);
+ ASSERT(!oldStyle || diff.needsFullLayout());
updateReflectionInfo(oldStyle);
}

Powered by Google App Engine
This is Rietveld 408576698