Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase; Renaming of some methods and small changes in StyleDifference Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 3771 matching lines...) Expand 10 before | Expand all | Expand 10 after
3782 3782
3783 void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle ) 3783 void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle )
3784 { 3784 {
3785 m_stackingNode->updateIsNormalFlowOnly(); 3785 m_stackingNode->updateIsNormalFlowOnly();
3786 m_stackingNode->updateStackingNodesAfterStyleChange(oldStyle); 3786 m_stackingNode->updateStackingNodesAfterStyleChange(oldStyle);
3787 3787
3788 if (m_scrollableArea) 3788 if (m_scrollableArea)
3789 m_scrollableArea->updateAfterStyleChange(oldStyle); 3789 m_scrollableArea->updateAfterStyleChange(oldStyle);
3790 3790
3791 if (!oldStyle || oldStyle->visibility() != renderer()->style()->visibility() ) { 3791 if (!oldStyle || oldStyle->visibility() != renderer()->style()->visibility() ) {
3792 ASSERT(!oldStyle || diff >= StyleDifferenceRepaint); 3792 ASSERT(!oldStyle || diff.needsRepaint() || diff.needsLayout());
3793 compositor()->setNeedsUpdateCompositingRequirementsState(); 3793 compositor()->setNeedsUpdateCompositingRequirementsState();
3794 } 3794 }
3795 3795
3796 // Overlay scrollbars can make this layer self-painting so we need 3796 // Overlay scrollbars can make this layer self-painting so we need
3797 // to recompute the bit once scrollbars have been updated. 3797 // to recompute the bit once scrollbars have been updated.
3798 updateSelfPaintingLayer(); 3798 updateSelfPaintingLayer();
3799 3799
3800 if (!oldStyle || renderer()->style()->position() != oldStyle->position()) { 3800 if (!oldStyle || renderer()->style()->position() != oldStyle->position()) {
3801 ASSERT(!oldStyle || diff >= StyleDifferenceLayout); 3801 ASSERT(!oldStyle || diff.needsFullLayout());
3802 updateOutOfFlowPositioned(oldStyle); 3802 updateOutOfFlowPositioned(oldStyle);
3803 } 3803 }
3804 3804
3805 if (!oldStyle || !renderer()->style()->reflectionDataEquivalent(oldStyle)) { 3805 if (!oldStyle || !renderer()->style()->reflectionDataEquivalent(oldStyle)) {
3806 ASSERT(!oldStyle || diff >= StyleDifferenceLayout); 3806 ASSERT(!oldStyle || diff.needsFullLayout());
3807 updateReflectionInfo(oldStyle); 3807 updateReflectionInfo(oldStyle);
3808 } 3808 }
3809 3809
3810 if (RuntimeEnabledFeatures::cssCompositingEnabled()) 3810 if (RuntimeEnabledFeatures::cssCompositingEnabled())
3811 m_blendInfo.updateBlendMode(); 3811 m_blendInfo.updateBlendMode();
3812 3812
3813 updateDescendantDependentFlags(); 3813 updateDescendantDependentFlags();
3814 3814
3815 if (!oldStyle || !renderer()->style()->transformDataEquivalent(*oldStyle)) 3815 if (!oldStyle || !renderer()->style()->transformDataEquivalent(*oldStyle))
3816 updateTransform(); 3816 updateTransform();
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
3995 } 3995 }
3996 } 3996 }
3997 3997
3998 void showLayerTree(const WebCore::RenderObject* renderer) 3998 void showLayerTree(const WebCore::RenderObject* renderer)
3999 { 3999 {
4000 if (!renderer) 4000 if (!renderer)
4001 return; 4001 return;
4002 showLayerTree(renderer->enclosingLayer()); 4002 showLayerTree(renderer->enclosingLayer());
4003 } 4003 }
4004 #endif 4004 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698