Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 236203019: Move UsbService to its own component. (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Move UsbService to its own component. This establishes a new usb_service component from the former contents of //chrome/browser/usb so that non-Chrome browser code may also depend upon it. BUG=361000 R=pfeldman@chromium.org TBR=derat@chromium.org for DEPS +chromeos TBR=cbentzel@chromium.org for DEPS +net/base Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265290

Patch Set 1 #

Patch Set 2 : ensure no usb_service target on ios or android #

Patch Set 3 : fix usb_service target dependencies #

Patch Set 4 : update tests gyp #

Patch Set 5 : export symbols properly #

Patch Set 6 : doh - fix export macro #

Patch Set 7 : Move usb_service component symbols into usb_service namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -2051 lines) Patch
A chrome/browser/devtools/device/usb/DEPS View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_device.h View 1 2 3 4 5 6 6 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_device.cc View 1 2 3 4 5 6 11 chunks +28 lines, -16 lines 0 comments Download
A chrome/browser/extensions/api/usb/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.h View 1 2 3 4 5 6 8 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.cc View 1 2 3 4 5 6 10 chunks +40 lines, -28 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_apitest.cc View 1 2 3 4 5 6 3 chunks +33 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.h View 1 2 3 4 5 6 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
D chrome/browser/usb/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/usb/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/usb/usb_context.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/usb/usb_context.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/usb/usb_context_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/usb/usb_device.h View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/usb/usb_device.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/usb/usb_device_handle.h View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/usb/usb_device_handle.cc View 1 chunk +0 lines, -603 lines 0 comments Download
D chrome/browser/usb/usb_interface.h View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/usb/usb_interface.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/usb/usb_service.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/usb/usb_service.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 5 chunks +2 lines, -13 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M components/OWNERS View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M components/components.gyp View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 6 3 chunks +8 lines, -0 lines 0 comments Download
A components/usb_service.gypi View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A components/usb_service/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
A + components/usb_service/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/usb_service/usb_context.h View 1 2 3 4 5 6 2 chunks +10 lines, -4 lines 0 comments Download
A + components/usb_service/usb_context.cc View 1 2 3 4 5 6 3 chunks +5 lines, -1 line 0 comments Download
A + components/usb_service/usb_context_unittest.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
A + components/usb_service/usb_device.h View 1 2 3 4 5 6 5 chunks +14 lines, -7 lines 0 comments Download
A + components/usb_service/usb_device.cc View 1 2 3 4 5 6 6 chunks +23 lines, -21 lines 0 comments Download
A + components/usb_service/usb_device_handle.h View 1 2 3 4 5 6 5 chunks +25 lines, -24 lines 0 comments Download
A + components/usb_service/usb_device_handle.cc View 1 2 3 4 5 6 22 chunks +197 lines, -142 lines 0 comments Download
A + components/usb_service/usb_interface.h View 1 2 3 4 5 6 8 chunks +16 lines, -11 lines 0 comments Download
A + components/usb_service/usb_interface.cc View 1 2 3 4 5 6 4 chunks +15 lines, -8 lines 0 comments Download
A + components/usb_service/usb_service.h View 1 2 3 4 5 6 4 chunks +14 lines, -5 lines 0 comments Download
A + components/usb_service/usb_service.cc View 1 2 3 4 5 6 2 chunks +7 lines, -3 lines 0 comments Download
A components/usb_service/usb_service_export.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ken Rockot(use gerrit already)
Pavel could you please take a look?
6 years, 8 months ago (2014-04-15 22:47:42 UTC) #1
pfeldman
lgtm. Please make sure it passes try bots (it currently fails).
6 years, 8 months ago (2014-04-16 06:38:11 UTC) #2
Ken Rockot(use gerrit already)
Looks like the remaining failures are not strictly related to this CL. +jochen@ could you ...
6 years, 8 months ago (2014-04-17 17:15:20 UTC) #3
jochen (gone - plz use gerrit)
can you please move the symbols into a new namespace? e.g. usb_service? otherwise lgtm
6 years, 8 months ago (2014-04-22 07:28:22 UTC) #4
Ken Rockot(use gerrit already)
On 2014/04/22 07:28:22, jochen wrote: > can you please move the symbols into a new ...
6 years, 8 months ago (2014-04-22 14:53:01 UTC) #5
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-22 14:53:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/236203019/110001
6 years, 8 months ago (2014-04-22 14:53:26 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 17:10:25 UTC) #8
Message was sent while issue was closed.
Change committed as 265290

Powered by Google App Engine
This is Rietveld 408576698