Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2849)

Unified Diff: chrome/browser/extensions/api/usb/usb_apitest.cc

Issue 236203019: Move UsbService to its own component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move usb_service component symbols into usb_service namespace Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/usb/usb_apitest.cc
diff --git a/chrome/browser/extensions/api/usb/usb_apitest.cc b/chrome/browser/extensions/api/usb/usb_apitest.cc
index d5dc252840213fb5ae027b4ffffd1eee641419be..4f2d72faf5560efd7a00aea6364ba092136eab2f 100644
--- a/chrome/browser/extensions/api/usb/usb_apitest.cc
+++ b/chrome/browser/extensions/api/usb/usb_apitest.cc
@@ -13,6 +13,11 @@ using testing::AnyNumber;
using testing::_;
using testing::Return;
using content::BrowserThread;
+using usb_service::UsbConfigDescriptor;
+using usb_service::UsbDevice;
+using usb_service::UsbDeviceHandle;
+using usb_service::UsbEndpointDirection;
+using usb_service::UsbTransferCallback;
namespace {
@@ -116,9 +121,11 @@ IN_PROC_BROWSER_TEST_F(UsbApiTest, ResetDevice) {
EXPECT_CALL(*mock_device_handle_.get(), ResetDevice())
.WillOnce(Return(true))
.WillOnce(Return(false));
- EXPECT_CALL(*mock_device_handle_.get(),
- InterruptTransfer(USB_DIRECTION_OUTBOUND, 2, _, 1, _, _))
- .WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_COMPLETED));
+ EXPECT_CALL(
+ *mock_device_handle_.get(),
+ InterruptTransfer(usb_service::USB_DIRECTION_OUTBOUND, 2, _, 1, _, _))
+ .WillOnce(
+ InvokeUsbTransferCallback<5>(usb_service::USB_TRANSFER_COMPLETED));
ASSERT_TRUE(RunExtensionTest("usb/reset_device"));
}
@@ -131,42 +138,45 @@ IN_PROC_BROWSER_TEST_F(UsbApiTest, ListInterfaces) {
IN_PROC_BROWSER_TEST_F(UsbApiTest, TransferEvent) {
EXPECT_CALL(*mock_device_handle_.get(),
- ControlTransfer(USB_DIRECTION_OUTBOUND,
+ ControlTransfer(usb_service::USB_DIRECTION_OUTBOUND,
UsbDeviceHandle::STANDARD,
UsbDeviceHandle::DEVICE,
- 1,
- 2,
- 3,
- _,
- 1,
- _,
- _))
- .WillOnce(InvokeUsbTransferCallback<9>(USB_TRANSFER_COMPLETED));
- EXPECT_CALL(*mock_device_handle_.get(),
- BulkTransfer(USB_DIRECTION_OUTBOUND, 1, _, 1, _, _))
- .WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_COMPLETED));
+ 1, 2, 3, _, 1, _, _))
+ .WillOnce(
+ InvokeUsbTransferCallback<9>(usb_service::USB_TRANSFER_COMPLETED));
EXPECT_CALL(*mock_device_handle_.get(),
- InterruptTransfer(USB_DIRECTION_OUTBOUND, 2, _, 1, _, _))
- .WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_COMPLETED));
+ BulkTransfer(usb_service::USB_DIRECTION_OUTBOUND, 1, _, 1, _, _))
+ .WillOnce(
+ InvokeUsbTransferCallback<5>(usb_service::USB_TRANSFER_COMPLETED));
+ EXPECT_CALL(
+ *mock_device_handle_.get(),
+ InterruptTransfer(usb_service::USB_DIRECTION_OUTBOUND, 2, _, 1, _, _))
+ .WillOnce(
+ InvokeUsbTransferCallback<5>(usb_service::USB_TRANSFER_COMPLETED));
EXPECT_CALL(*mock_device_handle_.get(),
- IsochronousTransfer(USB_DIRECTION_OUTBOUND, 3, _, 1, 1, 1, _, _))
- .WillOnce(InvokeUsbTransferCallback<7>(USB_TRANSFER_COMPLETED));
+ IsochronousTransfer(
+ usb_service::USB_DIRECTION_OUTBOUND, 3, _, 1, 1, 1, _, _))
+ .WillOnce(
+ InvokeUsbTransferCallback<7>(usb_service::USB_TRANSFER_COMPLETED));
EXPECT_CALL(*mock_device_handle_.get(), Close()).Times(AnyNumber());
ASSERT_TRUE(RunExtensionTest("usb/transfer_event"));
}
IN_PROC_BROWSER_TEST_F(UsbApiTest, ZeroLengthTransfer) {
EXPECT_CALL(*mock_device_handle_.get(), BulkTransfer(_, _, _, 0, _, _))
- .WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_COMPLETED));
+ .WillOnce(
+ InvokeUsbTransferCallback<5>(usb_service::USB_TRANSFER_COMPLETED));
EXPECT_CALL(*mock_device_handle_.get(), Close()).Times(AnyNumber());
ASSERT_TRUE(RunExtensionTest("usb/zero_length_transfer"));
}
IN_PROC_BROWSER_TEST_F(UsbApiTest, TransferFailure) {
EXPECT_CALL(*mock_device_handle_.get(), BulkTransfer(_, _, _, _, _, _))
- .WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_COMPLETED))
- .WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_ERROR))
- .WillOnce(InvokeUsbTransferCallback<5>(USB_TRANSFER_TIMEOUT));
+ .WillOnce(
+ InvokeUsbTransferCallback<5>(usb_service::USB_TRANSFER_COMPLETED))
+ .WillOnce(InvokeUsbTransferCallback<5>(usb_service::USB_TRANSFER_ERROR))
+ .WillOnce(
+ InvokeUsbTransferCallback<5>(usb_service::USB_TRANSFER_TIMEOUT));
EXPECT_CALL(*mock_device_handle_.get(), Close()).Times(AnyNumber());
ASSERT_TRUE(RunExtensionTest("usb/transfer_failure"));
}
« no previous file with comments | « chrome/browser/extensions/api/usb/usb_api.cc ('k') | chrome/browser/extensions/api/usb/usb_device_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698