Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 236203005: Remove EditableLinkBehavior, which is always set to NeverLive by Chromium. (Closed)

Created:
6 years, 8 months ago by jbroman
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove EditableLinkBehavior, which is always set to NeverLive by Chromium. On the Chromium side, there's a comment that this is unlikely to ever change. And indeed it has never changed since the initial commit of webkit/ in 2008. Thus this code is dead in Blink and should be removed. Chromium CL: https://codereview.chromium.org/236163005/ BUG=362961 TEST=ManualTests/contenteditable-link.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171412

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -200 lines) Patch
M Source/core/frame/Settings.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 chunk +1 line, -15 lines 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 8 chunks +5 lines, -117 lines 0 comments Download
M Source/core/page/EventHandler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 6 chunks +9 lines, -48 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbroman
Let me know if you know of any reason why we should keep this code. ...
6 years, 8 months ago (2014-04-13 18:38:24 UTC) #1
abarth-chromium
LGTM Thank you for removing dead code. If we want this feature in the future, ...
6 years, 8 months ago (2014-04-14 01:37:04 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-14 01:37:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/236203005/30001
6 years, 8 months ago (2014-04-14 01:37:23 UTC) #4
commit-bot: I haz the power
Change committed as 171412
6 years, 8 months ago (2014-04-14 01:54:19 UTC) #5
ojan
6 years, 8 months ago (2014-04-14 02:10:58 UTC) #6
Message was sent while issue was closed.
This is great! More patches like this please! :)

Powered by Google App Engine
This is Rietveld 408576698