Source/web/WebSettingsImpl.cpp - Issue 236203005: Remove EditableLinkBehavior, which is always set to NeverLive by Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSettingsImpl.cpp

Issue 236203005: Remove EditableLinkBehavior, which is always set to NeverLive by Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebSettingsImpl.cpp

diff --git a/Source/web/WebSettingsImpl.cpp b/Source/web/WebSettingsImpl.cpp

index f39df1c69d55c2163d2e0ef0d4e6f6fa596eafb0..e5aa108161903dbb8f68be8225e68d3d95021034 100644

--- a/Source/web/WebSettingsImpl.cpp

+++ b/Source/web/WebSettingsImpl.cpp

@@ -351,10 +351,7 @@ void WebSettingsImpl::setMaxTouchPoints(int maxTouchPoints)

void WebSettingsImpl::setEditableLinkBehaviorNeverLive()

{

- // FIXME: If you ever need more behaviors than this, then we should probably

- // define an enum in WebSettings.h and have a switch statement that

- // translates. Until then, this is probably fine, though.

- m_settings->setEditableLinkBehavior(WebCore::EditableLinkNeverLive);

+ // FIXME: remove once Chromium call site goes away

}

void WebSettingsImpl::setAllowUniversalAccessFromFileURLs(bool allow)

« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »