Disable flaky Android IME and selection tests.

Disable flaky Android IME and selection tests.

These tests (*all* Selection tests, and a few of the IME tests) are
extremely flaky to the point that they often cause waterfall redness
despite @RetryOnFailure.  These areas are actively owned (amaralp@ owns
Android selection, and changwan@/yabinh@ own Android IME) and we plan to
circle back to reenable without @RetryOnFailure when they have been
fully deflaked.

The @FlakyTest annotation is deprecated so also replace existing uses of
it with @DisabledTest, and secondly don't comment out the other
annotations which seems to be unnecessary nowadays.

BUG=649411, 628964, 592428
Committed: https://crrev.com/611dec311f31ead13d9c8648febc34dad1409c38
Cr-Commit-Position: refs/heads/master@{#420502}

[aelias_OOO_until_Jul13, 2016-09-22 21:22:36]

aelias@chromium.org changed reviewers:
+ boliu@chromium.org

[aelias_OOO_until_Jul13, 2016-09-22 21:22:40]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[aelias_OOO_until_Jul13, 2016-09-22 21:22:49]

Hi Bo, PTAL.

[commit-bot: I haz the power, 2016-09-22 21:23:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-09-22 22:26:31]

lgtm

[commit-bot: I haz the power, 2016-09-22 23:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:29:21]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2016-09-22 23:32:51]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:33:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:40:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-22 23:44:10]

Description was changed from

==========
Disable flaky Android IME and selection tests.

These tests (*all* Selection tests, and a few of the IME tests) are
extremely flaky to the point that they often cause waterfall redness
despite @RetryOnFailure.  These areas are actively owned (amaralp@ owns
Android selection, and changwan@/yabinh@ own Android IME) and we plan to
circle back to reenable without @RetryOnFailure when they have been
fully deflaked.

The @FlakyTest annotation is deprecated so also replace existing uses of
it with @DisabledTest, and secondly don't comment out the other
annotations which seems to be unnecessary nowadays.

BUG=649411,628964,592428
==========

to

==========
Disable flaky Android IME and selection tests.

These tests (*all* Selection tests, and a few of the IME tests) are
extremely flaky to the point that they often cause waterfall redness
despite @RetryOnFailure.  These areas are actively owned (amaralp@ owns
Android selection, and changwan@/yabinh@ own Android IME) and we plan to
circle back to reenable without @RetryOnFailure when they have been
fully deflaked.

The @FlakyTest annotation is deprecated so also replace existing uses of
it with @DisabledTest, and secondly don't comment out the other
annotations which seems to be unnecessary nowadays.

BUG=649411,628964,592428

Committed: https://crrev.com/611dec311f31ead13d9c8648febc34dad1409c38
Cr-Commit-Position: refs/heads/master@{#420502}
==========

[commit-bot: I haz the power, 2016-09-22 23:44:12]

Patchset 1 (id:??) landed as
https://crrev.com/611dec311f31ead13d9c8648febc34dad1409c38
Cr-Commit-Position: refs/heads/master@{#420502}

[jbudorick, 2016-09-22 23:54:30]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-09-22 23:54:31]

Just to confirm: you're correct about commenting out other annotations. The
presence of @DisabledTest or @FlakyTest now means the test will not run unless
specifically requested, even if other annotations are present.

[mfomitchev, 2016-09-23 16:25:47]

mfomitchev@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[mfomitchev, 2016-09-23 16:25:48]

https://codereview.chromium.org/2362013002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
(left):

https://codereview.chromium.org/2362013002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java:103:
@RetryOnFailure
Alex, did you mean to disable this one as well?

[aelias_OOO_until_Jul13, 2016-09-23 22:44:57]

On 2016/09/23 at 16:25:48, mfomitchev wrote:
>
https://codereview.chromium.org/2362013002/diff/1/content/public/android/java...
> File
content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
(left):
> 
>
https://codereview.chromium.org/2362013002/diff/1/content/public/android/java...
>
content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java:103:
@RetryOnFailure
> Alex, did you mean to disable this one as well?

Yes, thanks for catching my dumb mistake... I uploaded a one-liner for this at
https://codereview.chromium.org/2360333005.