Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2360333005: Actually disable testSelectionPreservedAfterReshown. (Closed)

Created:
4 years, 3 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam, mfomitchev
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Actually disable testSelectionPreservedAfterReshown. I made a text editing mistake in http://crrev.com/2362013002 and only removed @RetryOnFailure for this particular test without adding @DisabledTest as intended, thus actually increasing bot redness. TBR=boliu NOTRY=true BUG=649411, 592428 Committed: https://crrev.com/59e3a9e0896916dee88888a692d1f2a4c94d3102 Cr-Commit-Position: refs/heads/master@{#420767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360333005/1
4 years, 3 months ago (2016-09-23 22:53:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 23:00:01 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 23:02:57 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59e3a9e0896916dee88888a692d1f2a4c94d3102
Cr-Commit-Position: refs/heads/master@{#420767}

Powered by Google App Engine
This is Rietveld 408576698