MD Downloads: preload bold Roboto in a better way

MD Downloads: preload bold Roboto in a better way

R=tsergeant@chromium.org
BUG=648522
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f0beb1b34582ae0766013f6b84809f381d796fc3
Cr-Commit-Position: refs/heads/master@{#420517}

[Dan Beam, 2016-09-22 19:39:41]

Description was changed from

==========
MD Downloads: preload bold Roboto in a better way

R=tsergeant@chromium.org
BUG=648522
==========

to

==========
MD Downloads: preload bold Roboto in a better way

R=tsergeant@chromium.org
BUG=648522
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-22 19:40:47]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 19:41:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 21:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 21:33:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2016-09-22 23:01:26]

lgtm

https://codereview.chromium.org/2361973002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/downloads.js (right):

https://codereview.chromium.org/2361973002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/downloads.js:8: // TODO(dbeam): this is
copied out of roboto.css. I excluded roboto.css from
Is this actually a TODO, or can it just be a regular comment? There doesn't seem
to be anything actionable here.

[Dan Beam, 2016-09-22 23:37:24]

https://codereview.chromium.org/2361973002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/downloads.js (right):

https://codereview.chromium.org/2361973002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/downloads.js:8: // TODO(dbeam): this is
copied out of roboto.css. I excluded roboto.css from
On 2016/09/22 23:01:26, tsergeant wrote:
> Is this actually a TODO, or can it just be a regular comment? There doesn't
seem
> to be anything actionable here.

the TODO(dbeam) is just so it's easier to tell that I wrote it without needing
to blame the code or if it gets moved.

if we really wanted to, we could try to figure out how to serve roboto.css from
chrome://downloads ... or just turn off origin checking because we're chrome and
we can do what we want.

so those are options

[Dan Beam, 2016-09-22 23:37:28]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-09-22 23:37:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2361973002/#ps20001
(title: "!chromeos")

[commit-bot: I haz the power, 2016-09-22 23:38:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 00:59:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 01:03:16]

Description was changed from

==========
MD Downloads: preload bold Roboto in a better way

R=tsergeant@chromium.org
BUG=648522
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: preload bold Roboto in a better way

R=tsergeant@chromium.org
BUG=648522
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f0beb1b34582ae0766013f6b84809f381d796fc3
Cr-Commit-Position: refs/heads/master@{#420517}
==========

[commit-bot: I haz the power, 2016-09-23 01:03:17]

Patchset 2 (id:??) landed as
https://crrev.com/f0beb1b34582ae0766013f6b84809f381d796fc3
Cr-Commit-Position: refs/heads/master@{#420517}