Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2361733002: MD Downloads: hack to fix font flicker bug (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: hack to fix font flicker bug This renders a tiny bit of bold-weighted Roboto off screen so that the first time users hit bold Roboto (i.e. with keyboard focus on PAUSE/CANCEL/RESUME buttons) it doesn't flicker. BUG=640121, 648522 R=tsergeant@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/19579a56f727f6577f2f97fb71fd2c1224f2c692 Cr-Commit-Position: refs/heads/master@{#420400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/md_downloads/downloads.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Dan Beam
https://www.youtube.com/watch?v=drJWxMLrpE0
4 years, 2 months ago (2016-09-22 04:34:17 UTC) #2
tsergeant
this is...unusual, but lgtm
4 years, 2 months ago (2016-09-22 05:42:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361733002/1
4 years, 2 months ago (2016-09-22 18:16:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 18:22:29 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 18:26:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19579a56f727f6577f2f97fb71fd2c1224f2c692
Cr-Commit-Position: refs/heads/master@{#420400}

Powered by Google App Engine
This is Rietveld 408576698