Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 236193007: glDiscardFramebuffer() in GrGpuGL::discard uses invalid GLenum (Closed)

Created:
6 years, 8 months ago by siglesias
Modified:
6 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

glDiscardFramebuffer() in GrGpuGL::discard uses invalid GLenum According to the spec: "If a framebuffer object is bound to <target>, then <attachments> may contain COLOR_ATTACHMENT0, DEPTH_ATTACHMENT, and/or STENCIL_ATTACHMENT. If the framebuffer object is not complete, DiscardFramebufferEXT may be ignored. If the default framebuffer is bound to <target>, then <attachment> may contain COLOR, identifying the color buffer; DEPTH, identifying the depth buffer; or STENCIL, identifying the stencil buffer." Do the same as in glInvalidateFramebuffer() case. Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>; R=bsalomon@google.com BUG=skia:2411 Committed: http://code.google.com/p/skia/source/detail?r=14220

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/gpu/gl/GrGpuGL.cpp View 1 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
siglesias
6 years, 8 months ago (2014-04-14 08:20:31 UTC) #1
bsalomon
On 2014/04/14 08:20:31, samuelig wrote: lgtm, but can you change the tabs to 4 spaces?
6 years, 8 months ago (2014-04-15 14:38:49 UTC) #2
siglesias
On 2014/04/15 14:38:49, bsalomon wrote: > On 2014/04/14 08:20:31, samuelig wrote: > > lgtm, but ...
6 years, 8 months ago (2014-04-15 14:40:07 UTC) #3
siglesias
On 2014/04/15 14:40:07, samuelig wrote: > On 2014/04/15 14:38:49, bsalomon wrote: > > On 2014/04/14 ...
6 years, 8 months ago (2014-04-16 08:39:01 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-16 13:23:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/siglesias@igalia.com/236193007/20001
6 years, 8 months ago (2014-04-16 13:23:23 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 14:33:30 UTC) #7
Message was sent while issue was closed.
Change committed as 14220

Powered by Google App Engine
This is Rietveld 408576698