Don't write to an arbitrary address before crashing in blink's CRASH macro

Don't write to an arbitrary address before crashing in blink's CRASH macro

We could write to the first page which is write-protected everywhere, but
let's see if we can just remove this.  (If this breaks anyone's workflow,
please let me know.)

BUG=648620
Committed: https://crrev.com/cf2b885f31494c8006875e56cddef2840fffc9fa
Cr-Commit-Position: refs/heads/master@{#420374}

[Nico, 2016-09-22 13:49:59]

thakis@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Nico, 2016-09-22 13:50:07]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 13:50:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 15:34:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 15:34:47]

Dry run: This issue passed the CQ dry run.

[Martin Barbella, 2016-09-22 15:44:11]

lgtm

[Primiano Tucci (use gerrit), 2016-09-22 15:57:15]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-09-22 15:57:16]

+rsesek FYI
I glanced through the magic signature code and couldn't find anything specific
to "fbadbeef" so I think this change should be fine w.r.t. crash bucketing.

[Nico, 2016-09-22 16:52:25]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-09-22 16:52:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-09-22 16:55:08]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2016-09-22 16:55:08]

We don't normally (at all?) generate signatures based on crashed addresses, so
yes this should be fine.

[commit-bot: I haz the power, 2016-09-22 16:58:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-22 17:00:06]

Description was changed from

==========
Don't write to an arbitrary address before crashing in blink's CRASH macro

We could write to the first page which is write-protected everywhere, but
let's see if we can just remove this.  (If this breaks anyone's workflow,
please let me know.)

BUG=648620
==========

to

==========
Don't write to an arbitrary address before crashing in blink's CRASH macro

We could write to the first page which is write-protected everywhere, but
let's see if we can just remove this.  (If this breaks anyone's workflow,
please let me know.)

BUG=648620

Committed: https://crrev.com/cf2b885f31494c8006875e56cddef2840fffc9fa
Cr-Commit-Position: refs/heads/master@{#420374}
==========

[commit-bot: I haz the power, 2016-09-22 17:00:08]

Patchset 1 (id:??) landed as
https://crrev.com/cf2b885f31494c8006875e56cddef2840fffc9fa
Cr-Commit-Position: refs/heads/master@{#420374}