Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: third_party/WebKit/Source/wtf/Assertions.h

Issue 2361843002: Don't write to an arbitrary address before crashing in blink's CRASH macro (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/Assertions.h
diff --git a/third_party/WebKit/Source/wtf/Assertions.h b/third_party/WebKit/Source/wtf/Assertions.h
index d00b3aa526b1e4c29b38cef90d2c6e921a29bb82..234ed0c8b9889f76022a04a4af5257a78079a809 100644
--- a/third_party/WebKit/Source/wtf/Assertions.h
+++ b/third_party/WebKit/Source/wtf/Assertions.h
@@ -156,14 +156,11 @@ private:
// Macro is enabled in both debug and release mode.
// To test for unknown errors and verify assumptions, use ASSERT instead, to
// avoid impacting performance in release builds.
-//
-// Signals are ignored by the crash reporter on OS X so we must do better.
#ifndef CRASH
#if COMPILER(MSVC)
#define CRASH() (__debugbreak(), IMMEDIATE_CRASH())
#else
-#define CRASH() \
- (WTFReportBacktrace(), (*(int*)0xfbadbeef = 0), IMMEDIATE_CRASH())
+#define CRASH() (WTFReportBacktrace(), IMMEDIATE_CRASH())
#endif
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698