[turbofan] Don't take into account source size for inlining heuristics.

[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354, v8:5267
Committed: https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00a0cc1
Committed: https://crrev.com/0702ea3000df8235c8bfcf1e99a948ba38964ee3
Cr-Commit-Position: refs/heads/master@{#39681}

[Benedikt Meurer, 2016-09-22 10:50:06]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 10:50:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-09-22 10:52:09]

lgtm

[Benedikt Meurer, 2016-09-22 10:58:13]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-09-22 10:58:41]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-09-22 10:58:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-09-22 11:01:41]

lgtm

[commit-bot: I haz the power, 2016-09-22 11:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 11:41:37]

Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)

[Benedikt Meurer, 2016-09-23 04:33:14]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-09-23 04:33:14]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2361813002/#ps20001
(title: "Fix word32 vs word64 bug uncovered in CodeStubAssembler::UpdateFeedback
by this change.")

[commit-bot: I haz the power, 2016-09-23 04:33:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-23 04:34:15]

Description was changed from

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267
==========

to

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

Drive-by-fix: This change uncovered a bug in UpdateFeedback, where
we mix word32 and word64, which only showed on arm64 where this
distinction actually matters for instruction selection. Added an
appropriate regression test and fixed the bug.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267
==========

[Benedikt Meurer, 2016-09-23 04:38:17]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-09-23 04:38:18]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2361813002/#ps40001
(title: "Also handle appropriate baselining for test case.")

[commit-bot: I haz the power, 2016-09-23 04:38:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 05:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 05:04:29]

Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13312)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Benedikt Meurer, 2016-09-23 08:21:57]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 08:22:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-23 08:22:52]

Description was changed from

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

Drive-by-fix: This change uncovered a bug in UpdateFeedback, where
we mix word32 and word64, which only showed on arm64 where this
distinction actually matters for instruction selection. Added an
appropriate regression test and fixed the bug.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267
==========

to

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267
==========

[commit-bot: I haz the power, 2016-09-23 08:48:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 08:48:21]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13337)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Benedikt Meurer, 2016-09-23 11:45:18]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 11:45:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-23 11:46:52]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-09-23 11:47:20]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[commit-bot: I haz the power, 2016-09-23 11:47:25]

Description was changed from

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267
==========

to

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed: https://crrev.com/1b33028607637ba8cb2d60433811f825b00a0cc1
Cr-Commit-Position: refs/heads/master@{#39659}
==========

[commit-bot: I haz the power, 2016-09-23 11:47:26]

Patchset 4 (id:??) landed as
https://crrev.com/1b33028607637ba8cb2d60433811f825b00a0cc1
Cr-Commit-Position: refs/heads/master@{#39659}

[Benedikt Meurer, 2016-09-23 11:47:28]

Description was changed from

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed: https://crrev.com/1b33028607637ba8cb2d60433811f825b00a0cc1
Cr-Commit-Position: refs/heads/master@{#39659}
==========

to

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed:
https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00...
==========

[Benedikt Meurer, 2016-09-23 11:47:30]

Committed patchset #4 (id:60001) manually as
1b33028607637ba8cb2d60433811f825b00a0cc1 (presubmit successful).

[Michael Achenbach, 2016-09-23 12:42:54]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2362853003/ by machenbach@chromium.org.

The reason for reverting is: timeouts on windows:
https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds....

[Benedikt Meurer, 2016-09-23 13:02:08]

Description was changed from

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed:
https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00...
==========

to

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed:
https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00...
==========

[Benedikt Meurer, 2016-09-23 13:02:35]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 13:02:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 15:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 15:14:49]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer (Google), 2016-09-23 16:20:39]

The CQ bit was checked by bmeurer@google.com

[Benedikt Meurer (Google), 2016-09-23 16:20:39]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2361813002/#ps100001
(title: "Mozilla timeouts")

[commit-bot: I haz the power, 2016-09-23 16:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:23:24]

Description was changed from

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed:
https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00...
==========

to

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed:
https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00...
==========

[commit-bot: I haz the power, 2016-09-23 16:23:25]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-09-23 16:23:47]

Description was changed from

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed:
https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00...
==========

to

==========
[turbofan] Don't take into account source size for inlining heuristics.

The source size is not a real indicator for whether or not to inline a
certain function.

R=ishell@chromium.org, jarin@chromium.org
BUG=v8:3354,v8:5267

Committed:
https://chromium.googlesource.com/v8/v8/+/1b33028607637ba8cb2d60433811f825b00...
Committed: https://crrev.com/0702ea3000df8235c8bfcf1e99a948ba38964ee3
Cr-Commit-Position: refs/heads/master@{#39681}
==========

[commit-bot: I haz the power, 2016-09-23 16:23:48]

Patchset 5 (id:??) landed as
https://crrev.com/0702ea3000df8235c8bfcf1e99a948ba38964ee3
Cr-Commit-Position: refs/heads/master@{#39681}