Source/core/platform/text/TextBreakIterator.h - Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/text/TextBreakIterator.h

Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/TextCheckingHelper.cpp ('K') | « Source/core/platform/text/TextBoundaries.cpp ('k') | Source/core/platform/text/TextBreakIteratorICU.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/text/TextBreakIterator.h

diff --git a/Source/core/platform/text/TextBreakIterator.h b/Source/core/platform/text/TextBreakIterator.h

index d6de5590e0ec6d7fce90e184f0c726a0256b7151..d65902a78cbbb6df20f076d612e844ca3f00e950 100644

--- a/Source/core/platform/text/TextBreakIterator.h

+++ b/Source/core/platform/text/TextBreakIterator.h

@@ -27,7 +27,7 @@

namespace WebCore {

-class TextBreakIterator;

+typedef icu::BreakIterator TextBreakIterator;

// Note: The returned iterator is good only until you get another iterator, with the exception of acquireLineBreakIterator.

@@ -44,14 +44,6 @@ TextBreakIterator* acquireLineBreakIterator(const UChar*, int length, const Atom

void releaseLineBreakIterator(TextBreakIterator*);

TextBreakIterator* sentenceBreakIterator(const UChar*, int length);

-int textBreakFirst(TextBreakIterator*);

-int textBreakLast(TextBreakIterator*);

-int textBreakNext(TextBreakIterator*);

-int textBreakPrevious(TextBreakIterator*);

-int textBreakCurrent(TextBreakIterator*);

-int textBreakPreceding(TextBreakIterator*, int);

-int textBreakFollowing(TextBreakIterator*, int);

-bool isTextBreak(TextBreakIterator*, int);

bool isWordTextBreak(TextBreakIterator*);

const int TextBreakDone = -1;