Source/core/editing/TextCheckingHelper.cpp - Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TextCheckingHelper.cpp

Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/TextCheckingHelper.cpp

diff --git a/Source/core/editing/TextCheckingHelper.cpp b/Source/core/editing/TextCheckingHelper.cpp

index 33471b3344e82a97f8d8645b322b6558efee70d0..663c80397306141dcfc67df42b85ff593b71e2be 100644

--- a/Source/core/editing/TextCheckingHelper.cpp

+++ b/Source/core/editing/TextCheckingHelper.cpp

@@ -73,9 +73,9 @@ static void findMisspellings(TextCheckerClient& client, const UChar* text, int s

TextBreakIterator* iterator = wordBreakIterator(text + start, length);

if (!iterator)

return;

- int wordStart = textBreakCurrent(iterator);

+ int wordStart = iterator->current();

while (0 <= wordStart) {

- int wordEnd = textBreakNext(iterator);

+ int wordEnd = iterator->current();

leviw_travelin_and_unemployed 2013/09/17 21:53:39 It seems strange to me that these 2 lines are the

if (wordEnd < 0)

break;

int wordLength = wordEnd - wordStart;

« no previous file with comments | « no previous file | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »