Source/core/page/TouchAdjustment.cpp - Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/TouchAdjustment.cpp

Issue 23618052: TextBreakIterator should use the C++ icu API instead of the C one (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/TextCheckingHelper.cpp ('K') | « Source/core/editing/VisibleUnits.cpp ('k') | Source/core/platform/graphics/mac/ComplexTextController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/TouchAdjustment.cpp

diff --git a/Source/core/page/TouchAdjustment.cpp b/Source/core/page/TouchAdjustment.cpp

index fcd5901d796ef3d4c668a778d9efb704a5eb520c..5e742323b0615160f9dc1d6868ca580140f530ca 100644

--- a/Source/core/page/TouchAdjustment.cpp

+++ b/Source/core/page/TouchAdjustment.cpp

@@ -158,11 +158,11 @@ static inline void appendContextSubtargetsForNode(Node* node, SubtargetGeometryL

// Make subtargets out of every word.

String textValue = textNode->data();

TextBreakIterator* wordIterator = wordBreakIterator(textValue, 0, textValue.length());

- int lastOffset = textBreakFirst(wordIterator);

+ int lastOffset = wordIterator->first();

if (lastOffset == -1)

return;

int offset;

- while ((offset = textBreakNext(wordIterator)) != -1) {

+ while ((offset = wordIterator->next()) != -1) {

if (isWordTextBreak(wordIterator)) {

Vector<FloatQuad> quads;

textRenderer->absoluteQuadsForRange(quads, lastOffset, offset);