Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23618026: NOT FOR SUBMIT: Remove NetworkLibrary (Closed)

Created:
7 years, 3 months ago by gauravsh
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, dyu1, anantha, robertshield, oshima+watch_chromium.org, dennis_jeffrey, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove NetworkLibrary Gets rid of the last NetworkLibrary dependency in TestingAutomationProvider, which lets us remove NetworkLibrary and all its references. BUG=249525, 245494

Patch Set 1 #

Patch Set 2 : more rms #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11631 lines) Patch
M chrome/browser/automation/automation_provider.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 5 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 3 chunks +0 lines, -165 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers_chromeos.cc View 3 chunks +0 lines, -244 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 5 chunks +0 lines, -276 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 6 chunks +2 lines, -19 lines 0 comments Download
D chrome/browser/chromeos/cros/enum_mapper.h View 1 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/chromeos/cros/mock_network_library.h View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/chromeos/cros/mock_network_library.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/chromeos/cros/native_network_constants.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/chromeos/cros/native_network_constants.cc View 1 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/chromeos/cros/native_network_parser.h View 1 1 chunk +0 lines, -174 lines 0 comments Download
D chrome/browser/chromeos/cros/native_network_parser.cc View 1 chunk +0 lines, -1444 lines 0 comments Download
D chrome/browser/chromeos/cros/network_constants.h View 1 1 chunk +0 lines, -349 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library.h View 1 chunk +0 lines, -1590 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library.cc View 1 chunk +0 lines, -1395 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library_impl_base.h View 1 chunk +0 lines, -461 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library_impl_base.cc View 1 chunk +0 lines, -1595 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library_impl_cros.h View 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library_impl_cros.cc View 1 chunk +0 lines, -1302 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library_impl_stub.h View 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library_impl_stub.cc View 1 chunk +0 lines, -784 lines 0 comments Download
D chrome/browser/chromeos/cros/network_library_unittest.cc View 1 chunk +0 lines, -454 lines 0 comments Download
D chrome/browser/chromeos/cros/network_parser.h View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/browser/chromeos/cros/network_parser.cc View 1 chunk +0 lines, -218 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen_actor.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/functional/chromeos_wifi_sanity.py View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 2 chunks +0 lines, -164 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
I already had this trivial removal patch as part of crbug.com/249525 and crbug.com/245494. Figured I ...
7 years, 3 months ago (2013-09-03 01:01:57 UTC) #1
pneubeck (no reviews)
7 years, 3 months ago (2013-09-03 07:46:19 UTC) #2 
On 2013/09/03 01:01:57, gauravsh wrote:
> I already had this trivial removal patch as part of crbug.com/249525 and
> crbug.com/245494. Figured I will upload it and save you duplicated work.
> 
> Steven: After you close crbug.com/278514, feel free to do the honors of
landing
> this.
> 
> All: Finally!

Awesome!

Powered by Google App Engine
This is Rietveld 408576698