BrowserPlugin/WebView - Move plugin lifetime to DOM

Source/core/html/HTMLPlugInElement.h

Index: Source/core/html/HTMLPlugInElement.h
diff --git a/Source/core/html/HTMLPlugInElement.h b/Source/core/html/HTMLPlugInElement.h
index 33a69a078fa92c898f1a093ff453d286bdd75b6e..c6f3b71ce6ac468557782698881bd01bf451bf85 100644
--- a/Source/core/html/HTMLPlugInElement.h
+++ b/Source/core/html/HTMLPlugInElement.h
@@ -46,7 +46,6 @@ public:
 
     void resetInstance();
     SharedPersistent<v8::Object>* pluginWrapper();
-    Widget* pluginWidget() const;
     NPObject* getNPObject();
     bool canProcessDrag() const;
     const String& url() const { return m_url; }
@@ -56,6 +55,9 @@ public:
     void setNeedsWidgetUpdate(bool needsWidgetUpdate) { m_needsWidgetUpdate = needsWidgetUpdate; }
     void updateWidget();
 
+    void requestPluginCreationWithoutRendererIfPossible();
+    void createPluginWithoutRenderer();
+
 protected:
     HTMLPlugInElement(const QualifiedName& tagName, Document&, bool createdByParser, PreferPlugInsForImagesOption);
 
@@ -120,7 +122,7 @@ private:
     DisplayState displayState() const { return m_displayState; }
     void setDisplayState(DisplayState state) { m_displayState = state; }
     const String loadedMimeType() const;
-    bool loadPlugin(const KURL&, const String& mimeType, const Vector<String>& paramNames, const Vector<String>& paramValues, bool useFallback);
+    bool loadPlugin(const KURL&, const String& mimeType, const Vector<String>& paramNames, const Vector<String>& paramValues, bool useFallback, bool requireRenderer);
     bool pluginIsLoadable(const KURL&, const String& mimeType);
     bool wouldLoadAsNetscapePlugin(const String& url, const String& serviceType);
 
@@ -131,6 +133,8 @@ private:
     bool m_needsWidgetUpdate;
     bool m_shouldPreferPlugInsForImages;
     DisplayState m_displayState;
+
+    RefPtr<Widget> m_persistedPluginWidget;

[eseidel, 2013/12/12 20:40:13]

Why do we have two RefPtr<Widget>s in this patch?  Do these classes no longer
share a parent?

[wjmaclean, 2013/12/12 22:31:15]

Since "persistence" is a plugin-only concept, and HTMLFrameOwnerElement serves
plugins and non-plugins, I decided to move the pointer to this var while it's
being persisted. This also simplifies the logic in
HTMLFrameOwnerElement::setWidget(), and at any time the plugin widget pointer is
only ever in one of these locations.

 };
 
 DEFINE_NODE_TYPE_CASTS(HTMLPlugInElement, isPluginElement());