BrowserPlugin/WebView - Move plugin lifetime to DOM

Source/core/html/HTMLPlugInElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2006, 2007, 2008, 2009, 2012 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 28 matching lines @@
     ShouldPreferPlugInsForImages,
     ShouldNotPreferPlugInsForImages
 };
 
 class HTMLPlugInElement : public HTMLFrameOwnerElement {
 public:
     virtual ~HTMLPlugInElement();
 
     void resetInstance();
     SharedPersistent<v8::Object>* pluginWrapper();
-    Widget* pluginWidget() const;
     NPObject* getNPObject();
     bool canProcessDrag() const;
     const String& url() const { return m_url; }
 
     // Public for FrameView::addWidgetToUpdate()
     bool needsWidgetUpdate() const { return m_needsWidgetUpdate; }
     void setNeedsWidgetUpdate(bool needsWidgetUpdate) { m_needsWidgetUpdate = needsWidgetUpdate; }
     void updateWidget();
 
+    void requestPluginCreationWithoutRendererIfPossible();
+    void createPluginWithoutRenderer();
+
 protected:
     HTMLPlugInElement(const QualifiedName& tagName, Document&, bool createdByParser, PreferPlugInsForImagesOption);
 
     // Node functions:
     virtual void didMoveToNewDocument(Document& oldDocument) OVERRIDE;
     virtual bool dispatchBeforeLoadEvent(const String& sourceURL) OVERRIDE;
 
     // Element functions:
     virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;
     virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) OVERRIDE;
@@ skipping 44 matching lines @@
     virtual void updateWidgetInternal() = 0;
 
     enum DisplayState {
         Restarting,
         RestartingWithPendingMouseClick,
         Playing
     };
     DisplayState displayState() const { return m_displayState; }
     void setDisplayState(DisplayState state) { m_displayState = state; }
     const String loadedMimeType() const;
-    bool loadPlugin(const KURL&, const String& mimeType, const Vector<String>& paramNames, const Vector<String>& paramValues, bool useFallback);
+    bool loadPlugin(const KURL&, const String& mimeType, const Vector<String>& paramNames, const Vector<String>& paramValues, bool useFallback, bool requireRenderer);
     bool pluginIsLoadable(const KURL&, const String& mimeType);
     bool wouldLoadAsNetscapePlugin(const String& url, const String& serviceType);
 
     mutable RefPtr<SharedPersistent<v8::Object> > m_pluginWrapper;
     NPObject* m_NPObject;
     bool m_isCapturingMouseEvents;
     bool m_inBeforeLoadEventHandler;
     bool m_needsWidgetUpdate;
     bool m_shouldPreferPlugInsForImages;
     DisplayState m_displayState;
+
+    RefPtr<Widget> m_persistedPluginWidget;

[eseidel, 2013/12/12 20:40:13]

Why do we have two RefPtr<Widget>s in this patch?  Do these classes no longer
share a parent?

[wjmaclean, 2013/12/12 22:31:15]

Since "persistence" is a plugin-only concept, and HTMLFrameOwnerElement serves
plugins and non-plugins, I decided to move the pointer to this var while it's
being persisted. This also simplifies the logic in
HTMLFrameOwnerElement::setWidget(), and at any time the plugin widget pointer is
only ever in one of these locations.

 };
 
 DEFINE_NODE_TYPE_CASTS(HTMLPlugInElement, isPluginElement());
 
 } // namespace WebCore
 
 #endif // HTMLPlugInElement_h